From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 16FC381E89 for ; Mon, 14 Nov 2016 19:01:46 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 14 Nov 2016 19:01:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="31327030" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 14 Nov 2016 19:01:50 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Nov 2016 19:01:50 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Nov 2016 19:01:50 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Tue, 15 Nov 2016 11:01:48 +0800 From: "Gao, Liming" To: Leif Lindholm , "edk2-devel (edk2-devel@lists.01.org)" , "Wu, Hao A" CC: "Kinney, Michael D" , "Tian, Feng" , Andrew Fish , "Zeng, Star" Thread-Topic: [edk2] LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode Thread-Index: AQHSPpreFg1Xzv8R/0S2h8AfrA0c96DZVFeg Date: Tue, 15 Nov 2016 03:01:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B1F83@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 03:01:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: I think the first step is to update edk2 DSC files to use MdeModulePkg li= brary. Could you enter into one bug for it?=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Tuesday, November 15, 2016 1:17 AM > To: edk2-devel (edk2-devel@lists.01.org) ; Gao, > Liming ; Wu, Hao A > Cc: Kinney, Michael D ; Tian, Feng > ; Andrew Fish ; Zeng, Star > > Subject: [edk2] LzmaCustomDecompressLib and > PeiDxeDebugLibReportStatusCode >=20 > Hi all, >=20 > Digging through the tree, I spotted we have duplicate instances of the > above - one set in MdeModulePkg/Library/ and one in > IntelFrameworkModulePkg. >=20 > Looking though the log, I found the commit message explaining the situati= on: > --- > MdeModulePkg: Add two library instances >=20 > Copy below two library instances from IntelFrameworkModulePkg to > MdeModulePkg. Then, Platform dsc can > refer to them from MdeModulePkg, and remove the dependency of > IntelFrameworkModulePkg. The ones in > IntelFrameworkModulePkg are still kept for compatibility. > 1. PeiDxeDebugLibReportStatusCode > 2. LzmaCustomDecompressLib > --- >=20 > Even in the main tree, both versions of these are used. >=20 > Diffing the clones, 1) has diverged, with 8f77081 going into > MdeModulePkg and d5cbc27 into IntelFrameworkModulePkg. The > functionality is identical, but the code is not. >=20 > Can we re-evaluate the need to keep the "compatibility" copy around, > to reduce risk of further diversion? >=20 > Regards, >=20 > Leif > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel