public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb
Date: Wed, 16 Nov 2016 01:27:17 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B3811@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F564844E41@ORSMSX113.amr.corp.intel.com>

Mike:
  We don't need to add C tools .exe in edk2 git repo. All C tools .exe are in another git repo edk2-BaseTools-win32. And, Bin/Win32 directory is already in .gitignore. All exe files in Bin directory have been ignored.

Thanks
Liming
From: Kinney, Michael D
Sent: Wednesday, November 16, 2016 12:25 AM
To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb

Liming,

The current patch would ignore .exe in BaseTools/Bin

Since you had to add .exe, should this be done in .gitignore in
BaseTools/Source instead?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
> Sent: Tuesday, November 15, 2016 2:40 AM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files
> *.obj and *.pdb
>
> In V2, ignore .exe and .ilk files
>
> Cc: Yonghong Zhu
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao
> ---
> BaseTools/.gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore
> index 5ca024c..a45689b 100644
> --- a/BaseTools/.gitignore
> +++ b/BaseTools/.gitignore
> @@ -1,5 +1,9 @@
> *.d
> *.o
> +*.obj
> +*.pdb
> +*.ilk
> +*.exe
> *.pyc
> Source/C/VfrCompile/EfiVfrParser.cpp
> Source/C/VfrCompile/EfiVfrParser.h
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-11-16  1:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  6:29 [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming Gao
2016-11-15  7:03 ` Zhu, Yonghong
2016-11-15  7:16 ` Kinney, Michael D
2016-11-15 10:39 ` [PATCH v2] " Liming Gao
2016-11-15 16:25   ` Kinney, Michael D
2016-11-16  1:27     ` Gao, Liming [this message]
2016-11-16 16:36       ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4B3811@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox