From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8527081EB8 for ; Wed, 16 Nov 2016 00:48:19 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 16 Nov 2016 00:48:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,647,1473145200"; d="scan'208";a="31961386" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 16 Nov 2016 00:48:24 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 00:48:23 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 00:48:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Wed, 16 Nov 2016 16:48:21 +0800 From: "Gao, Liming" To: "Wu, Hao A" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] BaseTools/BuildEnv: Do not modify the env 'PACKAGES_PATH' in BuildEnv Thread-Index: AQHSP+YJAfBV2mBM6E6CMFBHPfd9R6DbTItw Date: Wed, 16 Nov 2016 08:48:20 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B400D@shsmsx102.ccr.corp.intel.com> References: <1479286025-17912-1-git-send-email-hao.a.wu@intel.com> In-Reply-To: <1479286025-17912-1-git-send-email-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/BuildEnv: Do not modify the env 'PACKAGES_PATH' in BuildEnv X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2016 08:48:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, November 16, 2016 4:47 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming ; > Zhu, Yonghong > Subject: [PATCH] BaseTools/BuildEnv: Do not modify the env > 'PACKAGES_PATH' in BuildEnv >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D236 >=20 > The script 'BuildEnv' modifies the value of the environment variable > 'PACKAGES_PATH' (line 44). The script will substitute the ':' symbol > (seperating multiple paths) with a space. >=20 > This is not supposed to happen since users might later use 'PACKAGES_PATH= ' > during the code-building process under a multiple-workspace scenario. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Hao Wu > --- > BaseTools/BuildEnv | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv > index cb6403a..f748811 100755 > --- a/BaseTools/BuildEnv > +++ b/BaseTools/BuildEnv > @@ -2,7 +2,7 @@ > # Setup the environment for unix-like systems running a bash-like shell. > # This file must be "sourced" not merely executed. For example: ". > edksetup.sh" > # > -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the = BSD > License > @@ -41,8 +41,8 @@ RestorePreviousConfiguration() { > export CONF_PATH=3D$WORKSPACE/Conf > if [ ! -d $WORKSPACE/Conf ] && [ -n "$PACKAGES_PATH" ] > then > - PACKAGES_PATH=3D${PACKAGES_PATH//:/ } > - for DIR in $PACKAGES_PATH > + PATH_LIST=3D${PACKAGES_PATH//:/ } > + for DIR in $PATH_LIST > do > if [ -d $DIR/Conf ] > then > @@ -138,8 +138,8 @@ SetEdkToolsPath() { > # > if [ -n "$PACKAGES_PATH"] > then > - PACKAGES_PATH=3D${PACKAGES_PATH//:/ } > - for DIR in $PACKAGES_PATH > + PATH_LIST=3D${PACKAGES_PATH//:/ } > + for DIR in $PATH_LIST > do > if [ -d $DIR/BaseTools ] > then > -- > 1.9.5.msysgit.0