From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 74E8D81F22 for ; Wed, 16 Nov 2016 16:55:55 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP; 16 Nov 2016 16:56:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,650,1473145200"; d="scan'208,217";a="32237911" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 16 Nov 2016 16:56:00 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 16:56:00 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 16:55:59 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Thu, 17 Nov 2016 08:55:57 +0800 From: "Gao, Liming" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] MdePkg Base.h: Add add comments on __ prefix in enum VERIFY_UINTXX_ENUM_SIZE Thread-Index: AQHSP8/jDNjKz5iUT0G/qZAhvHnXN6DbTDwAgAEOs3A= Date: Thu, 17 Nov 2016 00:55:56 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B4688@shsmsx102.ccr.corp.intel.com> References: <1479276464-25196-1-git-send-email-liming.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFmZGNhOWYtYjk0Zi00MTBiLWFkZTEtZjNhMDNlM2I3NWIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkgwMEJobU9mQjk3a2xQdGpmd01ialYwNGJmYUZzREdJMTJIN21xdlQ1Q009In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Patch] MdePkg Base.h: Add add comments on __ prefix in enum VERIFY_UINTXX_ENUM_SIZE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 00:55:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got you. I will update comments and push this change. From: Kinney, Michael D Sent: Thursday, November 17, 2016 12:47 AM To: Gao, Liming ; edk2-devel@lists.01.org; Kinney, Mi= chael D Subject: RE: [edk2] [Patch] MdePkg Base.h: Add add comments on __ prefix in= enum VERIFY_UINTXX_ENUM_SIZE Liming, Here is a wording update that also references the part of the UEFI Spec that defines the enum type requirements. // // The following three enum types are used to verify that the compiler // configuration for enum types is compliant with Section 2.3.1 of the // UEFI 2.3 Specification. These enum types and enum values are not // intended to be used. A prefix of '__' is used avoid conflicts with // other types. // Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Li= ming Gao > Sent: Tuesday, November 15, 2016 10:08 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: [edk2] [Patch] MdePkg Base.h: Add add comments on __ prefix in e= num > VERIFY_UINTXX_ENUM_SIZE > > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > MdePkg/Include/Base.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index 5e24b5d..c758cf3 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -63,6 +63,11 @@ VERIFY_SIZE_OF (UINT64, 8); > VERIFY_SIZE_OF (CHAR8, 1); > VERIFY_SIZE_OF (CHAR16, 2); > > +// > +// Those three enum types are only used to verify compiler config is rig= ht. > +// They are not used by any source code. So, __ prefix is added for them= to > +// avoid their name conflict with other types. > +//> typedef enum { > __VerifyUint8EnumValue =3D 0xff > } __VERIFY_UINT8_ENUM_SIZE; > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel