public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization.
Date: Thu, 17 Nov 2016 06:34:21 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B4BBA@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1479176926-24656-1-git-send-email-eric.dong@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Dong, Eric
> Sent: Tuesday, November 15, 2016 10:29 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [Patch] MdeModulePkg HiiDatabase: Remove extra memory
> initialization.
> 
> The memory will be set to background color after success allocate
> the data, so not need to call AllocateZeroPool.
> 
> Related bugz: https://bugzilla.tianocore.org/show_bug.cgi?id=223
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> index 7855c7e..9bef064 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> @@ -2056,7 +2056,7 @@ HiiStringToImage (
>      if ((Flags & EFI_HII_DIRECT_TO_SCREEN) == EFI_HII_DIRECT_TO_SCREEN) {
>        BltBuffer = NULL;
>        if (RowInfo[RowIndex].LineWidth != 0) {
> -        BltBuffer = AllocateZeroPool (RowInfo[RowIndex].LineWidth *
> RowInfo[RowIndex].LineHeight * sizeof
> (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
> +        BltBuffer = AllocatePool (RowInfo[RowIndex].LineWidth *
> RowInfo[RowIndex].LineHeight * sizeof
> (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
>          if (BltBuffer == NULL) {
>            Status = EFI_OUT_OF_RESOURCES;
>            goto Exit;
> --
> 2.6.4.windows.1



      reply	other threads:[~2016-11-17  6:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  2:28 [Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization Eric Dong
2016-11-17  6:34 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4B4BBA@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox