From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B00B81E30 for ; Thu, 17 Nov 2016 20:58:33 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 17 Nov 2016 20:58:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="1086923790" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 17 Nov 2016 20:58:38 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 20:58:37 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 18 Nov 2016 12:58:35 +0800 From: "Gao, Liming" To: Gary Lin , Laszlo Ersek CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console Thread-Index: AQHSP66hs4wL5rYTmE6Tis9RBLumFqDdljyAgACa4eA= Date: Fri, 18 Nov 2016 04:58:34 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B5B7B@shsmsx102.ccr.corp.intel.com> References: <1479262207-25836-1-git-send-email-liming.gao@intel.com> <20161118034259.n5xfainraki2gm7q@GaryWorkstation> In-Reply-To: <20161118034259.n5xfainraki2gm7q@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 04:58:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Lin: Please run . edksetup.sh --reconfig to reset your local configure files.= =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, November 18, 2016 11:43 AM > To: Gao, Liming ; Laszlo Ersek > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to > describe QEMU debug console >=20 > On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > > Cc: Laszlo Ersek > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Liming Gao >=20 > Hi Liming and Laszlo, >=20 > I failed to compile OVMF after applying this patch: >=20 > "iasl" - > p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTa > bles/AcpiTables/OUTPUT/./Dsdt.aml > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii > Compiler aborting due to parser-detected syntax error(s) > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii 375: IO (Decode16, FixedP= cdGet16 > (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > Error 6126 - = syntax error, > unexpected PARSEOP_NAMESEG ^ >=20 > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii 440: > Error 6126 - syntax error, unexpected '}', expecting $end and prematur= e > End-Of-File >=20 > The acpica version in my system is 20160422. Did I missing any update in > acpica? >=20 > Thanks, >=20 > Gary Lin >=20 > > --- > > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf > b/OvmfPkg/AcpiTables/AcpiTables.inf > > index 1187a14..2c604c3 100644 > > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > > @@ -37,4 +37,8 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + OvmfPkg/OvmfPkg.dec > > + > > +[Pcd] > > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > > index 2c3a314..0397722 100644 > > --- a/OvmfPkg/AcpiTables/Dsdt.asl > > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", > "OVMF ", 4) { > > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU deb= ug console, > should use FixedPcdGet16 (PcdDebugIoPort) > > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet1= 6 > (PcdDebugIoPort), 0x00, 0x01) > > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > > -- > > 2.8.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel