From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen
Date: Wed, 30 Nov 2016 00:38:34 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4BAF13@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1480419672-23664-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Tuesday, November 29, 2016 7:41 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen
>
> Fix the bug to add PaletteSize info into AutoGen.c when the flag
> UEFI_HII_RESOURCE_SECTION is set to FALSE.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/GenC.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index de6eb0e..63cfe04 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -1693,14 +1693,15 @@ def CreateIdfFileCode(Info, AutoGenC, StringH,
> IdfGenCFlag, IdfGenBinBuffer):
> TempBuffer += Buffer
> elif File.Ext.upper() == '.BMP':
> TempBuffer, TempPalette = BmpImageDecoder(File, Buffer,
> PaletteIndex, FileObj.TransParent)
> if len(TempPalette) > 1:
> PaletteIndex += 1
> - PaletteBuffer += pack('H', len(TempPalette))
> - PaletteBuffer += TempPalette
> + NewPalette = pack('H', len(TempPalette))
> + NewPalette += TempPalette
> + PaletteBuffer += NewPalette
> PaletteStr = WriteLine(PaletteStr, '// %s: %s: %s' %
> (DecToHexStr(PaletteIndex - 1, 4), ID, DecToHexStr(PaletteIndex - 1, 4)))
> - TempPaletteList = AscToHexList(TempPalette)
> + TempPaletteList = AscToHexList(NewPalette)
> PaletteStr = WriteLine(PaletteStr,
> CreateArrayItem(TempPaletteList, 16) + '\n')
> ImageBuffer += TempBuffer
> BufferStr = WriteLine(BufferStr, '// %s: %s: %s' %
> (DecToHexStr(Index, 4), ID, DecToHexStr(Index, 4)))
> TempBufferList = AscToHexList(TempBuffer)
> BufferStr = WriteLine(BufferStr,
> CreateArrayItem(TempBufferList, 16) + '\n')
> --
> 2.6.1.windows.1
prev parent reply other threads:[~2016-11-30 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 11:41 [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen Yonghong Zhu
2016-11-30 0:38 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14B4BAF13@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox