public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode
@ 2016-11-14 17:16 Leif Lindholm
  2016-11-15  3:01 ` Gao, Liming
  0 siblings, 1 reply; 8+ messages in thread
From: Leif Lindholm @ 2016-11-14 17:16 UTC (permalink / raw)
  To: edk2-devel (edk2-devel@lists.01.org), Gao, Liming, Hao Wu
  Cc: Feng Tian, Star Zeng, Andrew Fish, Kinney, Michael D

Hi all,

Digging through the tree, I spotted we have duplicate instances of the
above - one set in MdeModulePkg/Library/ and one in
IntelFrameworkModulePkg.

Looking though the log, I found the commit message explaining the situation:
---
MdeModulePkg: Add two library instances

    Copy below two library instances from IntelFrameworkModulePkg to
MdeModulePkg. Then, Platform dsc can
    refer to them from MdeModulePkg, and remove the dependency of
IntelFrameworkModulePkg. The ones in
    IntelFrameworkModulePkg are still kept for compatibility.
    1. PeiDxeDebugLibReportStatusCode
    2. LzmaCustomDecompressLib
---

Even in the main tree, both versions of these are used.

Diffing the clones, 1) has diverged, with 8f77081 going into
MdeModulePkg and d5cbc27 into IntelFrameworkModulePkg. The
functionality is identical, but the code is not.

Can we re-evaluate the need to keep the "compatibility" copy around,
to reduce risk of further diversion?

Regards,

Leif


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-12-01 10:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14 17:16 LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode Leif Lindholm
2016-11-15  3:01 ` Gao, Liming
2016-11-30 17:20   ` [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-11-30 20:08     ` Laszlo Ersek
2016-12-01  1:12     ` Gao, Liming
2016-12-01  1:52     ` Zeng, Star
2016-12-01 10:23       ` Leif Lindholm
2016-12-01  2:29     ` Kinney, Michael D

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox