From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 91D1981C69 for ; Wed, 14 Dec 2016 20:36:52 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 14 Dec 2016 20:36:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,350,1477983600"; d="scan'208";a="1072246476" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 14 Dec 2016 20:36:52 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 20:36:51 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 20:36:51 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.9]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.97]) with mapi id 14.03.0248.002; Thu, 15 Dec 2016 12:36:49 +0800 From: "Gao, Liming" To: "Palmer, Thomas" , Laszlo Ersek , Bruce Cran , "edk2-devel (edk2-devel@lists.01.org)" CC: "Wu, Hao A" , "Ni, Ruiyu" Thread-Topic: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same") Thread-Index: AQHSQIBPTbyGSQttkkm0YqECUAj9uaDc6umAgABhbACAAAvPAIAq0wgAgABs/RA= Date: Thu, 15 Dec 2016 04:36:48 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6A55B7@SHSMSX104.ccr.corp.intel.com> References: <47cd17d8-f022-6ca5-2f52-06a8250f8d14@cran.org.uk> <886a3cc4-3dcb-db33-cc74-cbe4c6714d09@cran.org.uk> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: OVMF: cross-filesystem copy broken? ("The source and destination are the same") X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 04:36:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This should be root cause.=20 edk2\MdePkg\Library\BaseLib\String.c line 554 to implement InternalCharToUp= per() with EFIAPI. CHAR16 EFIAPI InternalCharToUpper ( IN CHAR16 Char ) edk2\ShellPkg\Library\UefiShellLevel2CommandsLib\UefiShellLevel2CommandsLib= .c line 271 declares it without EFIAPI. So, they don't match each other.=20 CHAR16 InternalCharToUpper ( IN CONST CHAR16 Char ); Thanks Liming > -----Original Message----- > From: Palmer, Thomas [mailto:thomas.palmer@hpe.com] > Sent: Thursday, December 15, 2016 6:09 AM > To: Laszlo Ersek ; Bruce Cran ; > edk2-devel (edk2-devel@lists.01.org) > Cc: Wu, Hao A ; Ni, Ruiyu ; Gao, > Liming > Subject: RE: [edk2] OVMF: cross-filesystem copy broken? ("The source and > destination are the same") >=20 > Laszlo, et al~ >=20 > I recently encountered a "cp" failure on OVMF whereby cp always thought > my source and destination file paths were equivalent. Turns out that > StrniCmp function was broken b/c the InternalCharToUpper declaration in > UefiShellLevel2CommandsLib.c was missing the EFIAPI token. Once I added > EFIAPI back, my cp command worked. >=20 > I'm on vacation so I can't write up a formal patch right now. Give it a= try and > if it works please write up a patch, else I'll get back to it when I get = back. >=20 >=20 > Regards, >=20 > Thomas Palmer >=20 > "I have only made this letter longer because I have not had the time to m= ake > it shorter" - Blaise Pascal >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, November 17, 2016 10:07 AM > To: Bruce Cran ; edk2-devel (edk2-devel@lists.01.org) > > Cc: Wu, Hao A ; Ni, Ruiyu ; Gao, > Liming > Subject: Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and > destination are the same") >=20 > On 11/17/16 16:24, Bruce Cran wrote: > > On 11/17/2016 2:35 AM, Laszlo Ersek wrote: > > > >> There's a patch on the list for said BZ: > >> [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths > >> properly > >> > >> so if the BZ is indeed what you're encountering, then the patch > >> should fix it for you. Can you please test it and report back in that = thread? > > > > Unfortunately the patch doesn't fix the problem I'm seeing. > > >=20 > Thanks for trying it. >=20 > Unfortunately, I can't find the time to dig into this now. And, I think i= t's likely > related to ShellPkg anyway. Can you please help by filing a BZ for ShellP= kg, > and/or bisecting the issue (assuming you remember the same command > working at some point)? >=20 > ... I observe that the least recent commit that affected "Cp.c" with any > potential to break it like this could be >=20 > commit fbd2dfadfe6fb16ab7b49fca3764e05e65d97b8a > Author: Qiu Shumin > Date: Fri Oct 23 02:03:20 2015 +0000 >=20 > ShellPkg: Follow spec to remove the last '\' char in return name of > GetCurDir(). >=20 > but that commit is more than a year old now... So I'm not sure. Could be = one > of the underlying helper functions. Time to pull out GDB and single step = the > code? :) >=20 > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel