public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Correct bin wrappers for GenDepex.py path
Date: Mon, 19 Dec 2016 06:00:04 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6B2679@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482118193-5884-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Monday, December 19, 2016 11:30 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Correct bin wrappers for GenDepex.py path
> 
> The WindowsLike and PosixLike bin wrappers for GenDepex.py do not use
> correct path. GenDepex.py is not in a GenDepex directory. Instead, it is
> in the AutoGen directory.
> 
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=292
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/BinWrappers/PosixLike/GenDepex       | 2 +-
>  BaseTools/BinWrappers/WindowsLike/GenDepex.bat | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/BinWrappers/PosixLike/GenDepex
> b/BaseTools/BinWrappers/PosixLike/GenDepex
> index 214d88f..bdb6722 100755
> --- a/BaseTools/BinWrappers/PosixLike/GenDepex
> +++ b/BaseTools/BinWrappers/PosixLike/GenDepex
> @@ -9,6 +9,6 @@ fi
>  full_cmd=${BASH_SOURCE:-$0} # see
> http://mywiki.wooledge.org/BashFAQ/028 for a discussion of why $0 is not a
> good choice here
>  dir=$(dirname "$full_cmd")
>  cmd=${full_cmd##*/}
> 
>  export PYTHONPATH="$dir/../../Source/Python"
> -exec "${python_exe:-python}" "$dir/../../Source/Python/$cmd/$cmd.py"
> "$@"
> +exec "${python_exe:-python}"
> "$dir/../../Source/Python/AutoGen/$cmd.py" "$@"
> diff --git a/BaseTools/BinWrappers/WindowsLike/GenDepex.bat
> b/BaseTools/BinWrappers/WindowsLike/GenDepex.bat
> index 9fbb704..ffc783d 100644
> --- a/BaseTools/BinWrappers/WindowsLike/GenDepex.bat
> +++ b/BaseTools/BinWrappers/WindowsLike/GenDepex.bat
> @@ -1,3 +1,3 @@
>  @setlocal
>  @set ToolName=%~n0%
> -
> @%PYTHON_HOME%\python.exe %BASE_TOOLS_PATH%\Source\Python\%
> ToolName%\%ToolName%.py %*
> +@%PYTHON_HOME%\python.exe %BASE_TOOLS_PATH%\Source\Python\
> AutoGen\%ToolName%.py %*
> --
> 2.6.1.windows.1



      reply	other threads:[~2016-12-19  6:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  3:29 [Patch] BaseTools: Correct bin wrappers for GenDepex.py path Yonghong Zhu
2016-12-19  6:00 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6B2679@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox