From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug for RAW file alignment value support
Date: Thu, 29 Dec 2016 08:49:34 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6C72D7@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482833179-28356-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Tuesday, December 27, 2016 6:06 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [Patch] BaseTools: Fix the bug for RAW file alignment value
> support
>
> Fix the bug for RAW file to support Align=32 and Align=64. Current FDF
> spec FfsAlignmentValues support this two values, while it is not the
> valid value for GenFfs. So this patch add the logic to handle it.
>
> Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=248
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> index c3f3624..d02befe 100644
> --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
> @@ -427,15 +427,22 @@ class GenFdsGlobalVariable:
>
> @staticmethod
> def GenerateFfs(Output, Input, Type, Guid, Fixed=False, CheckSum=False,
> Align=None,
> SectionAlign=None):
> Cmd = ["GenFfs", "-t", Type, "-g", Guid]
> + mFfsValidAlign = ["0", "8", "16", "128", "512", "1K", "4K", "32K", "64K"]
> if Fixed == True:
> Cmd += ["-x"]
> if CheckSum:
> Cmd += ["-s"]
> if Align not in [None, '']:
> + if Align not in mFfsValidAlign:
> + Align = GenFdsGlobalVariable.GetAlignment (Align)
> + for index in range(0, len(mFfsValidAlign) - 1):
> + if ((Align >
> GenFdsGlobalVariable.GetAlignment(mFfsValidAlign[index])) and (Align <=
> GenFdsGlobalVariable.GetAlignment(mFfsValidAlign[index + 1]))):
> + break
> + Align = mFfsValidAlign[index + 1]
> Cmd += ["-a", Align]
>
> Cmd += ["-o", Output]
> for I in range(0, len(Input)):
> Cmd += ("-i", Input[I])
> --
> 2.6.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-12-29 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:06 [Patch] BaseTools: Fix the bug for RAW file alignment value support Yonghong Zhu
2016-12-29 8:49 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6C72D7@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox