Re: [PATCH v3 0/4] BaseIoFifoLib

["Gao, Liming" <liming.gao@intel.com>]

Leo:
  FifoIo is one width type of EFI_CPU_IO_PROTOCOL_WIDTH. So, how about add new APIs into IoLib together with other Io APIs? If so, no new library class is required. Platform DSC files are not required to be changed. 

Thanks
Liming
>-----Original Message-----
>From: Leo Duran [mailto:leo.duran@amd.com]
>Sent: Friday, January 06, 2017 5:49 AM
>To: edk2-devel@lists.01.org
>Cc: brijesh.singh@amd.com; lersek@redhat.com; Justen, Jordan L
><jordan.l.justen@intel.com>; Fan, Jeff <jeff.fan@intel.com>; Kinney, Michael
>D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ma,
>Maurice <maurice.ma@intel.com>; Agyeman, Prince
><prince.agyeman@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Steele, Kelly
><kelly.steele@intel.com>; Wei, David <david.wei@intel.com>; Guo, Mang
><mang.guo@intel.com>; Leo Duran <leo.duran@amd.com>
>Subject: [PATCH v3 0/4] BaseIoFifoLib
>
>The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate
>implementations of I/O Fifo routines. The patch series moves the I/O Fifo
>routines into a common BaseIofifoLib library supporting IA32 and X64
>architectures under MdePkg.
>
>The intent of this patch series is twofold:
>1) Consolidate I/O Fifo routines into a common BaseIofifoLib library.
>2) Allow override of BaseIofifoLib for specific platform implementations.
>For example, the OVMF package can provide its own version of BaseIoFifoLib
>to support Secure Encrypted Virtualization (SEV) guests, since SEV does not
>support string I/O instructions (rep ins/outs), and requires unrolled loops
>of single in/out instructions.
>
>Brijesh Singh (4):
>  MdePkg: Add BaseIoFifoLib library
>  Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
>  Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library.
>  Modify QemuFwCfgLib to use new BaseIoFifoLib library.
>
> CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc      |   3 +
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc   |   3 +
> DuetPkg/DuetPkgIa32.dsc                            |   2 +
> DuetPkg/DuetPkgX64.dsc                             |   2 +
> MdePkg/Include/Library/IoFifoLib.h                 | 176 +++++++++++++
> MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf     |  44 ++++
> .../Library/BaseIoFifoLib}/Ia32/IoFifo.asm         | 280 ++++++++++-----------
> .../Library/BaseIoFifoLib}/Ia32/IoFifo.nasm        | 272 ++++++++++----------
> .../Library/BaseIoFifoLib}/X64/IoFifo.asm          | 252 +++++++++----------
> .../Library/BaseIoFifoLib}/X64/IoFifo.nasm         | 250 +++++++++---------
> MdePkg/MdePkg.dec                                  |   4 +
> MdePkg/MdePkg.dsc                                  |   2 +
> OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm  |  55 ----
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c        |  54 +---
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf      |   8 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf   |   8 +-
> OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm   |  52 ----
> OvmfPkg/OvmfPkgIa32.dsc                            |   2 +
> OvmfPkg/OvmfPkgIa32X64.dsc                         |   2 +
> OvmfPkg/OvmfPkgX64.dsc                             |   2 +
> QuarkPlatformPkg/Quark.dsc                         |   2 +
> QuarkPlatformPkg/QuarkMin.dsc                      |   2 +
> UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c                   |   3 +-
> UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.h                   |   3 +
> UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf                 |  12 +-
> UefiCpuPkg/UefiCpuPkg.dsc                          |   2 +
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |   2 +
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |   2 +
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |   2 +
> 29 files changed, 794 insertions(+), 709 deletions(-)
> create mode 100644 MdePkg/Include/Library/IoFifoLib.h
> create mode 100644 MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf
> rename {UefiCpuPkg/CpuIo2Dxe =>
>MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.asm (96%)
> rename {UefiCpuPkg/CpuIo2Dxe =>
>MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.nasm (96%)
> rename {UefiCpuPkg/CpuIo2Dxe =>
>MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.asm (97%)
> rename {UefiCpuPkg/CpuIo2Dxe =>
>MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.nasm (97%)
> delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
> delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm
>
>--
>1.9.1