From: "Gao, Liming" <liming.gao@intel.com>
To: "Ma, Maurice" <maurice.ma@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file
Date: Tue, 10 Jan 2017 05:06:11 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CB709@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1b538262c95e26b1daa0345f947b88172439f666.1484019131.git.maurice.ma@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Maurice Ma
>Sent: Tuesday, January 10, 2017 11:33 AM
>To: edk2-devel@lists.01.org
>Cc: Agyeman, Prince <prince.agyeman@intel.com>
>Subject: [edk2] [PATCH 1/1] CorebootPayloadPkg: Remove improper build
>flags in DSC file
>
>Current CorebootPayloadPkgIa32X64.dsc contains "-flto" flag to
>request GCC link time optimization. However, this feature is
>only supported by newer GCC compiler, and it will break the
>debug build with GCC4.8. To fix it, the extra compiling flags
>are removed. It allows the default build flags set by the EDKII
>build environment to be used.
>
>With this fix, CorebootPayloadPkg 64bit debug build can pass
>using GCC 4.8.
>
>Cc: Prince Agyeman <prince.agyeman@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Maurice Ma <maurice.ma@intel.com>
>---
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>index c35f261d67be..6b16af63ba89 100644
>--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>@@ -89,8 +89,6 @@
>
> [BuildOptions]
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>- GCC:DEBUG_*_*_CC_FLAGS = -Og -flto
>- GCC:DEBUG_*_*_DLINK_FLAGS = -flto
> GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG
> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
>--
>2.11.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-01-10 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 3:32 [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file Maurice Ma
2017-01-10 5:06 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6CB709@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox