[PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

[PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

[Maurice Ma]

Current CorebootPayloadPkgIa32X64.dsc contains "-flto" flag to
request GCC link time optimization. However, this feature is
only supported by newer GCC compiler, and it will break the
debug build with GCC4.8. To fix it, the extra compiling flags
are removed. It allows the default build flags set by the EDKII
build environment to be used.

With this fix, CorebootPayloadPkg 64bit debug build can pass
using GCC 4.8.

Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
---
 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
index c35f261d67be..6b16af63ba89 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
@@ -89,8 +89,6 @@
 
 [BuildOptions]
   *_*_*_CC_FLAGS                 = -D DISABLE_NEW_DEPRECATED_INTERFACES
-  GCC:DEBUG_*_*_CC_FLAGS         = -Og -flto
-  GCC:DEBUG_*_*_DLINK_FLAGS      = -flto
   GCC:*_UNIXGCC_*_CC_FLAGS       = -DMDEPKG_NDEBUG
   GCC:RELEASE_*_*_CC_FLAGS       = -DMDEPKG_NDEBUG
   INTEL:RELEASE_*_*_CC_FLAGS     = /D MDEPKG_NDEBUG
-- 
2.11.0.windows.1

Re: [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Maurice Ma
>Sent: Tuesday, January 10, 2017 11:33 AM
>To: edk2-devel@lists.01.org
>Cc: Agyeman, Prince <prince.agyeman@intel.com>
>Subject: [edk2] [PATCH 1/1] CorebootPayloadPkg: Remove improper build
>flags in DSC file
>
>Current CorebootPayloadPkgIa32X64.dsc contains "-flto" flag to
>request GCC link time optimization. However, this feature is
>only supported by newer GCC compiler, and it will break the
>debug build with GCC4.8. To fix it, the extra compiling flags
>are removed. It allows the default build flags set by the EDKII
>build environment to be used.
>
>With this fix, CorebootPayloadPkg 64bit debug build can pass
>using GCC 4.8.
>
>Cc: Prince Agyeman <prince.agyeman@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Maurice Ma <maurice.ma@intel.com>
>---
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>index c35f261d67be..6b16af63ba89 100644
>--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
>@@ -89,8 +89,6 @@
>
> [BuildOptions]
>   *_*_*_CC_FLAGS                 = -D DISABLE_NEW_DEPRECATED_INTERFACES
>-  GCC:DEBUG_*_*_CC_FLAGS         = -Og -flto
>-  GCC:DEBUG_*_*_DLINK_FLAGS      = -flto
>   GCC:*_UNIXGCC_*_CC_FLAGS       = -DMDEPKG_NDEBUG
>   GCC:RELEASE_*_*_CC_FLAGS       = -DMDEPKG_NDEBUG
>   INTEL:RELEASE_*_*_CC_FLAGS     = /D MDEPKG_NDEBUG
>--
>2.11.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel