From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28DDA817E4 for ; Tue, 10 Jan 2017 17:41:43 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 10 Jan 2017 17:41:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="1110825154" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 10 Jan 2017 17:41:42 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:41:42 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:41:42 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 09:41:37 +0800 From: "Gao, Liming" To: Leo Duran , "edk2-devel@lists.01.org" CC: "brijesh.singh@amd.com" , "Justen, Jordan L" , "Kinney, Michael D" , "lersek@redhat.com" , "Fan, Jeff" Thread-Topic: [edk2] [PATCH 0/8] IoLib class library Thread-Index: AQHSa50iC7Ys/qgCT0SH1GFmweqAHaEydEvQ Date: Wed, 11 Jan 2017 01:41:36 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CCE7E@shsmsx102.ccr.corp.intel.com> References: <1484092554-26224-1-git-send-email-leo.duran@amd.com> In-Reply-To: <1484092554-26224-1-git-send-email-leo.duran@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/8] IoLib class library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 01:41:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leo: Thanks for your update. Here is my comments.=20 1) PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2 library instance can base on CPU= IO service to do FifoIo operation. They don't implement them again. 2) IntelFrameworkModulePkg CpuIoDxe and UefiCpuPkg CpuIoPei driver can be u= pdated to base on FifoIo API for their FifoIo implementation. 3) One coding style issue. We don't assign value to the variable declaratio= n.=20 UINT8 *Buffer8 =3D (UINT8 *)Buffer; =3D=3D> UINT8 *Buffer8; Buffer8 =3D (UINT8 *)Buffer; Thanks Liming -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leo = Duran Sent: Wednesday, January 11, 2017 7:56 AM To: edk2-devel@lists.01.org Cc: brijesh.singh@amd.com; Justen, Jordan L ; Ga= o, Liming ; Leo Duran ; Kinney, Mi= chael D ; lersek@redhat.com; Fan, Jeff Subject: [edk2] [PATCH 0/8] IoLib class library The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch series moves the I/O Fifo routines into the BaseIoLibIntrinsic library and expands the IoLib class to include the ported I/O Fifo routines. The Fifo routines moved from the UefiCpuPkg/CpuIo2Dxe driver support IA32 and X64 natively, and other architectures are supported by simply looping through the basic IoRead/IoWrite routines as appropiate. The intent of this patch series is twofold: 1) Integrate I/O Fifo routines into the IoLib class library. 2) Allow override of IoLib as may be required to support specific hardware implementations, such as AMD's Secure Encrypted Virtualization (SEV). Leo Duran (8): MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib class library OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library IntelFrameworkPkg/Library/DxeIoLibCpuIo/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Include/Library/IoLib.h | 158 ++++++++++++++++ .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 6 +- .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm | 1 + .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm | 1 + MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c | 182 +++++++++++++++++= + MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c | 179 +++++++++++++++++= + MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c | 201 +++++++++++++++++= +++ .../Library/BaseIoLibIntrinsic}/X64/IoFifo.asm | 1 + .../Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm | 1 + MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/DxeIoLibEsal/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/PeiIoLibCpuIo/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 203 +++++++++++++++++= ++++ OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 ------ OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 54 +----- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ------ UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 3 +- UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf | 11 +- UefiCpuPkg/CpuIo2Dxe/IoFifo.h | 176 -----------------= - 22 files changed, 1751 insertions(+), 359 deletions(-) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/= IoFifo.asm (94%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/= IoFifo.nasm (94%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/X64/I= oFifo.asm (95%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/X64/I= oFifo.nasm (95%) delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm delete mode 100644 UefiCpuPkg/CpuIo2Dxe/IoFifo.h --=20 1.9.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel