Re: [PATCH 0/8] IoLib class library

["Gao, Liming" <liming.gao@intel.com>]

Jeff:
  This patch moves source files from UefiCpuPkg to MdePkg. .asm and .nasm are not new added ones. So, I suggest to keep them. 

Thanks
Liming
-----Original Message-----
From: Fan, Jeff 
Sent: Wednesday, January 11, 2017 9:45 AM
To: Gao, Liming <liming.gao@intel.com>; Leo Duran <leo.duran@amd.com>; edk2-devel@lists.01.org
Cc: brijesh.singh@amd.com; Justen, Jordan L <jordan.l.justen@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; lersek@redhat.com
Subject: RE: [edk2] [PATCH 0/8] IoLib class library

Leo,

I suggest not to add .asm file again. It's hard to maintain in the future, because VS and GCC compile .nasm file by default now.

Liming, any comments?

Thanks!
Jeff

-----Original Message-----
From: Gao, Liming 
Sent: Wednesday, January 11, 2017 9:42 AM
To: Leo Duran; edk2-devel@lists.01.org
Cc: brijesh.singh@amd.com; Justen, Jordan L; Kinney, Michael D; lersek@redhat.com; Fan, Jeff
Subject: RE: [edk2] [PATCH 0/8] IoLib class library

Leo:
  Thanks for your update. Here is my comments. 
1) PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2 library instance can base on CPU IO service to do FifoIo operation. They don't implement them again.
2) IntelFrameworkModulePkg CpuIoDxe and UefiCpuPkg CpuIoPei driver can be updated to base on FifoIo API for their FifoIo implementation.
3) One coding style issue. We don't assign value to the variable declaration. 
UINT8 *Buffer8 = (UINT8 *)Buffer;
==>
UINT8 *Buffer8;
Buffer8 = (UINT8 *)Buffer;

Thanks
Liming
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leo Duran
Sent: Wednesday, January 11, 2017 7:56 AM
To: edk2-devel@lists.01.org
Cc: brijesh.singh@amd.com; Justen, Jordan L <jordan.l.justen@intel.com>; Gao, Liming <liming.gao@intel.com>; Leo Duran <leo.duran@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>; lersek@redhat.com; Fan, Jeff <jeff.fan@intel.com>
Subject: [edk2] [PATCH 0/8] IoLib class library

The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch series moves the I/O Fifo routines into the BaseIoLibIntrinsic library and expands the IoLib class to include the ported I/O Fifo routines.

The Fifo routines moved from the UefiCpuPkg/CpuIo2Dxe driver support IA32 and X64 natively, and other architectures are supported by simply looping through the basic IoRead/IoWrite routines as appropiate.

The intent of this patch series is twofold:
1) Integrate I/O Fifo routines into the IoLib class library.
2) Allow override of IoLib as may be required to support specific hardware implementations, such as AMD's Secure Encrypted Virtualization (SEV).

Leo Duran (8):
  MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library
  MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class
  MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class
  MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class
  MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class
  IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class
  UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib class library
  OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library

 IntelFrameworkPkg/Library/DxeIoLibCpuIo/IoLib.c    | 203 +++++++++++++++++++++
 MdePkg/Include/Library/IoLib.h                     | 158 ++++++++++++++++
 .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf      |   6 +-
 .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm    |   1 +
 .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm   |   1 +
 MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c       | 182 ++++++++++++++++++
 MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c       | 179 ++++++++++++++++++
 MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c       | 201 ++++++++++++++++++++
 .../Library/BaseIoLibIntrinsic}/X64/IoFifo.asm     |   1 +
 .../Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm    |   1 +
 MdePkg/Library/DxeIoLibCpuIo2/IoLib.c              | 203 +++++++++++++++++++++
 MdePkg/Library/DxeIoLibEsal/IoLib.c                | 203 +++++++++++++++++++++
 MdePkg/Library/PeiIoLibCpuIo/IoLib.c               | 203 +++++++++++++++++++++
 MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c           | 203 +++++++++++++++++++++
 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm  |  55 ------
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c        |  54 +-----
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf      |   7 +-
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf   |   7 +-
 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm   |  52 ------
 UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c                   |   3 +-
 UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf                 |  11 +-
 UefiCpuPkg/CpuIo2Dxe/IoFifo.h                      | 176 ------------------
 22 files changed, 1751 insertions(+), 359 deletions(-)  rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm (94%)  rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm (94%)  rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoLibIntrinsic}/X64/IoFifo.asm (95%)  rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm (95%)  delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
 delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm
 delete mode 100644 UefiCpuPkg/CpuIo2Dxe/IoFifo.h

--
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel