From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E504B81C9B for ; Sat, 14 Jan 2017 05:00:26 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 14 Jan 2017 05:00:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,227,1477983600"; d="scan'208";a="213314630" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 14 Jan 2017 05:00:26 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 14 Jan 2017 05:00:26 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 14 Jan 2017 05:00:26 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Sat, 14 Jan 2017 21:00:22 +0800 From: "Gao, Liming" To: Leo Duran , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Fan, Jeff" , "Justen, Jordan L" , "lersek@redhat.com" , "brijesh.singh@amd.com" Thread-Topic: [PATCH v3 00/10] IoLib class library Thread-Index: AQHSbdkgUAAUb0b7BUqXLFAtchx/m6E37/bQ Date: Sat, 14 Jan 2017 13:00:22 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CED38@shsmsx102.ccr.corp.intel.com> References: <1484338200-31337-1-git-send-email-leo.duran@amd.com> In-Reply-To: <1484338200-31337-1-git-send-email-leo.duran@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 00/10] IoLib class library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 13:00:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leo: Thanks for your update. I have no other comments. Reviewed-by: Liming Gao= Thanks Liming -----Original Message----- From: Leo Duran [mailto:leo.duran@amd.com]=20 Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Kinney, Michael D ; Fan, Jeff ; Justen, Jordan L ; lersek@redhat.com; brijesh.singh@amd.com; Leo Duran Subject: [PATCH v3 00/10] IoLib class library The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch series moves the I/O Fifo routines into the BaseIoLibIntrinsic library and expands the IoLib class to include the ported I/O Fifo routines. The Fifo routines moved from the UefiCpuPkg/CpuIo2Dxe driver support IA32 and X64 natively, and other architectures are supported by simply looping through the basic IoRead/IoWrite routines as appropiate. The intent of this patch series is twofold: 1) Integrate I/O Fifo routines into the IoLib class library. 2) Allow override of IoLib as may be required to support specific hardware implementations, such as AMD's Secure Encrypted Virtualization (SEV). Changes since v2: - Rework DxeIoLibEsal to use FiFo routines via the CPU I/O interfaces. Changes only to: [PATCH v2 07/10] MdePkg/DxeIoLibEsal Leo Duran (10): MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib library UefiCpuPkg: Modify CpuIoPei to support new IoLib library IntelFrameworkModulePkg: Modify CpuIoDxe to support new IoLib library MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library IntelFrameworkModulePkg/Universal/CpuIoDxe/CpuIo.c | 52 ++++ .../Library/DxeIoLibCpuIo/DxeCpuIoLibInternal.h | 70 +++++- IntelFrameworkPkg/Library/DxeIoLibCpuIo/IoLib.c | 248 +++++++++++++++++= + MdePkg/Include/Library/IoLib.h | 152 +++++++++++ .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 6 +- .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm | 19 +- .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm | 19 +- MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c | 169 +++++++++++++ MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c | 171 +++++++++++++ MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c | 201 +++++++++++++++ .../Library/BaseIoLibIntrinsic}/X64/IoFifo.asm | 19 +- .../Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm | 19 +- .../Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h | 71 +++++- MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 260 +++++++++++++++++= +- MdePkg/Library/DxeIoLibEsal/IoLib.c | 278 +++++++++++++++++= +++- MdePkg/Library/PeiIoLibCpuIo/IoLib.c | 261 +++++++++++++++++= ++ MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 216 ++++++++++++++++ OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 ---- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 54 +--- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ---- UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 13 +- UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf | 11 +- UefiCpuPkg/CpuIo2Dxe/IoFifo.h | 176 ------------- UefiCpuPkg/CpuIoPei/CpuIoPei.c | 52 ++++ 26 files changed, 2239 insertions(+), 419 deletions(-) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/= IoFifo.asm (85%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/= IoFifo.nasm (86%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/X64/I= oFifo.asm (83%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/X64/I= oFifo.nasm (84%) delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm delete mode 100644 UefiCpuPkg/CpuIo2Dxe/IoFifo.h --=20 1.9.1