public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1
Date: Tue, 24 Jan 2017 07:24:48 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D41AE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1485073063-211620-2-git-send-email-star.zeng@intel.com>

Star:
  Please fix the incorrect character in comments. With this change, I add my Reviewed-by: Liming Gao <liming.gao@intel.com>

+/// 00h �C 3Fh: MCTP Host Interfaces

Thanks
Liming
>-----Original Message-----
>From: Zeng, Star
>Sent: Sunday, January 22, 2017 4:18 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=349
>
>This patch is to add definitions for below items.
>Processor Information (Type 4):
>- add socket SP3r2
>- add AMD Zen Processor Family
>Management Controller Host Interface (Type 42):
>- include Host Interface Type and Protocol Identifier enumerations
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdePkg/Include/IndustryStandard/SmBios.h | 25
>+++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
>diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
>b/MdePkg/Include/IndustryStandard/SmBios.h
>index f5c29bcbd0c8..6a8fa1b39d17 100644
>--- a/MdePkg/Include/IndustryStandard/SmBios.h
>+++ b/MdePkg/Include/IndustryStandard/SmBios.h
>@@ -611,6 +611,7 @@ typedef enum {
>   ProcessorFamilyAmdOpteronX2000Series  = 0x68,
>   ProcessorFamilyAmdOpteronASeries      = 0x69,
>   ProcessorFamilyAmdOpteronX3000Series  = 0x6A,
>+  ProcessorFamilyAmdZen                 = 0x6B,
>   ProcessorFamilyHobbit                 = 0x70,
>   ProcessorFamilyCrusoeTM5000           = 0x78,
>   ProcessorFamilyCrusoeTM3000           = 0x79,
>@@ -804,7 +805,8 @@ typedef enum {
>   ProcessorUpgradeSocketBGA1440   = 0x34,
>   ProcessorUpgradeSocketBGA1515   = 0x35,
>   ProcessorUpgradeSocketLGA3647_1 = 0x36,
>-  ProcessorUpgradeSocketSP3       = 0x37
>+  ProcessorUpgradeSocketSP3       = 0x37,
>+  ProcessorUpgradeSocketSP3r2     = 0x38
> } PROCESSOR_UPGRADE;
>
> ///
>@@ -2386,6 +2388,25 @@ typedef struct {
> } SMBIOS_TABLE_TYPE41;
>
> ///
>+/// Management Controller Host Interface - Interface Types.
>+/// 00h �C 3Fh: MCTP Host Interfaces
>+///
>+typedef enum{
>+  MCHostInterfaceTypeNetworkHostInterface       = 0x40,
>+  MCHostInterfaceTypeOemDefined                 = 0xF0
>+} MC_HOST_INTERFACE_TYPE;
>+
>+///
>+/// Management Controller Host Interface - Protocol Types.
>+///
>+typedef enum{
>+  MCHostInterfaceProtocolTypeIPMI               = 0x02,
>+  MCHostInterfaceProtocolTypeMCTP               = 0x03,
>+  MCHostInterfaceProtocolTypeRedfishOverIP      = 0x04,
>+  MCHostInterfaceProtocolTypeOemDefined         = 0xF0
>+} MC_HOST_INTERFACE_PROTOCOL_TYPE;
>+
>+///
> /// Management Controller Host Interface (Type 42).
> ///
> /// The information in this structure defines the attributes of a Management
>@@ -2404,7 +2425,7 @@ typedef struct {
> ///
> typedef struct {
>   SMBIOS_STRUCTURE                  Hdr;
>-  UINT8                             InterfaceType;
>+  UINT8                             InterfaceType;          ///< The enumeration value from
>MC_HOST_INTERFACE_TYPE
>   UINT8                             MCHostInterfaceData[1]; ///< This field has a minimum
>of four bytes
> } SMBIOS_TABLE_TYPE42;
>
>--
>2.7.0.windows.1


  reply	other threads:[~2017-01-24  7:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22  8:17 [PATCH 0/3] Add SMBIOS spec 3.1.1 support Star Zeng
2017-01-22  8:17 ` [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1 Star Zeng
2017-01-24  7:24   ` Gao, Liming [this message]
2017-01-24  7:25     ` Zeng, Star
2017-01-22  8:17 ` [PATCH 2/3] MdeModulePkg: Update PcdSmbiosDocRev to 0x1 " Star Zeng
2017-01-24  7:27   ` Tian, Feng
2017-01-22  8:17 ` [PATCH 3/3] ShellPkg SmbiosView: Add decoding of " Star Zeng
2017-01-22  8:56   ` Ni, Ruiyu
2017-01-22  9:24     ` Zeng, Star
2017-01-22  9:49       ` Ni, Ruiyu
2017-01-23 17:40         ` Carsey, Jaben
2017-01-23 20:51           ` Tim Lewis
2017-01-23 21:14             ` Carsey, Jaben
2017-01-23 21:25               ` Tim Lewis
2017-01-23 21:47                 ` Carsey, Jaben
2017-01-23 21:57                   ` Tim Lewis
2017-01-23 21:59                     ` Carsey, Jaben
2017-01-23 22:02                       ` Tim Lewis
2017-01-24  6:56             ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6D41AE@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox