From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D06948208E for ; Thu, 2 Feb 2017 19:38:46 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 02 Feb 2017 19:38:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,327,1477983600"; d="scan'208";a="1090323519" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 02 Feb 2017 19:38:46 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Feb 2017 19:38:44 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Feb 2017 19:38:44 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 11:38:42 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Fan, Jeff" Thread-Topic: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros Thread-Index: AQHSd5rDH/0rTKlbO0SkSnh1ItzpmKFWrqJQ Date: Fri, 3 Feb 2017 03:38:42 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6239@shsmsx102.ccr.corp.intel.com> References: <20170126060927.352436-1-ruiyu.ni@intel.com> <20170126060927.352436-2-ruiyu.ni@intel.com> In-Reply-To: <20170126060927.352436-2-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 03:38:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray: How about wrap them by macro DISABLE_NEW_DEPRECATED_INTERFACES to avoid t= hem be used any more? Thanks Liming >-----Original Message----- >From: Ni, Ruiyu >Sent: Thursday, January 26, 2017 2:09 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Fan, Jeff >Subject: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec >IncompatiblePciDevice macros > >DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 >should be used to match any VendorId/DeviceId/RevisionId/ >SubsystemVendorId/SubsystemDeviceId. > >PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ >PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such >definitions. > >PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64) -1 should be >used to match all BARs. > >All of the above macros are marked as deprecated. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Ruiyu Ni >Cc: Liming Gao >Cc: Jeff Fan >--- > MdePkg/Include/IndustryStandard/Pci22.h | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > >diff --git a/MdePkg/Include/IndustryStandard/Pci22.h >b/MdePkg/Include/IndustryStandard/Pci22.h >index 4cf8389..8f87b04 100644 >--- a/MdePkg/Include/IndustryStandard/Pci22.h >+++ b/MdePkg/Include/IndustryStandard/Pci22.h >@@ -780,14 +780,18 @@ typedef struct { > /// > } EFI_PCI_CAPABILITY_HOTPLUG; > >-#define DEVICE_ID_NOCARE 0xFFFF >+/// >+/// Below macros (till PCI_BAR_ALL) were used by >EfiIncompatiblePciDeviceSupport Protocol. >+/// Some of them don't match Spec or are not defined in Spec. Those are >marked as deprecated. >+/// >+#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't >match Spec. > > #define PCI_ACPI_UNUSED 0 > #define PCI_BAR_NOCHANGE 0 >-#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL >-#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL >-#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL >-#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL >+#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. >Value isn't defined in Spec. > > #define PCI_BAR_IDX0 0x00 > #define PCI_BAR_IDX1 0x01 >@@ -795,7 +799,7 @@ typedef struct { > #define PCI_BAR_IDX3 0x03 > #define PCI_BAR_IDX4 0x04 > #define PCI_BAR_IDX5 0x05 >-#define PCI_BAR_ALL 0xFF >+#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't match = Spec. > > /// > /// EFI PCI Option ROM definitions >-- >2.9.0.windows.1