From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 011AB82007 for ; Mon, 6 Feb 2017 00:18:05 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 06 Feb 2017 00:18:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,341,1477983600"; d="scan'208";a="930583106" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 06 Feb 2017 00:18:05 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Feb 2017 00:18:05 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Feb 2017 00:18:05 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Mon, 6 Feb 2017 16:18:01 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Fan, Jeff" Thread-Topic: [PATCH v2 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros Thread-Index: AQHSgD5v9ODnwoH9WkW8gwAD8ePvDKFboobA Date: Mon, 6 Feb 2017 08:18:01 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6E67@shsmsx102.ccr.corp.intel.com> References: <20170206060059.595976-1-ruiyu.ni@intel.com> <20170206060059.595976-7-ruiyu.ni@intel.com> In-Reply-To: <20170206060059.595976-7-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 08:18:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Ni, Ruiyu >Sent: Monday, February 06, 2017 2:01 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Fan, Jeff >Subject: [PATCH v2 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec >IncompatiblePciDevice macros > >DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 >should be used to match any VendorId/DeviceId/RevisionId/ >SubsystemVendorId/SubsystemDeviceId. > >PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ >PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such >definitions. > >PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64) -1 should be >used to match all BARs. > >All of the above macros are marked as deprecated. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Ruiyu Ni >Cc: Liming Gao >Cc: Jeff Fan >--- > MdePkg/Include/IndustryStandard/Pci22.h | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) > >diff --git a/MdePkg/Include/IndustryStandard/Pci22.h >b/MdePkg/Include/IndustryStandard/Pci22.h >index 4cf8389..5dec65d 100644 >--- a/MdePkg/Include/IndustryStandard/Pci22.h >+++ b/MdePkg/Include/IndustryStandard/Pci22.h >@@ -7,7 +7,7 @@ > PC Card Standard, 8.0 > PCI Power Management Interface Specifiction, Revision 1.2 > >- Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
>+ Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> Copyright (c) 2014 - 2015, Hewlett-Packard Development Company, L.P. > This program and the accompanying materials > are licensed and made available under the terms and conditions of the B= SD >License >@@ -780,14 +780,25 @@ typedef struct { > /// > } EFI_PCI_CAPABILITY_HOTPLUG; > >-#define DEVICE_ID_NOCARE 0xFFFF >+/// >+/// Below macros (till PCI_BAR_NOCHANGE) were used by >EfiIncompatiblePciDeviceSupport Protocol. >+/// >+#ifndef DISABLE_NEW_DEPRECATED_INTERFACES >+ >+/// >+/// [ATTENTION] These macros are deprecated because they don't match >Spec or not defined in Spec. >+/// >+#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value >doesn't match Spec. >+#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. >Value isn't defined in Spec. >+#define PCI_BAR_ALL 0xFF ///< Deprecated. Value= doesn't >match Spec. >+ >+#endif > > #define PCI_ACPI_UNUSED 0 > #define PCI_BAR_NOCHANGE 0 >-#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL >-#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL >-#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL >-#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL > > #define PCI_BAR_IDX0 0x00 > #define PCI_BAR_IDX1 0x01 >@@ -795,7 +806,6 @@ typedef struct { > #define PCI_BAR_IDX3 0x03 > #define PCI_BAR_IDX4 0x04 > #define PCI_BAR_IDX5 0x05 >-#define PCI_BAR_ALL 0xFF > > /// > /// EFI PCI Option ROM definitions >-- >2.9.0.windows.1