From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B9E0181EDE for ; Thu, 9 Feb 2017 19:29:37 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Feb 2017 19:29:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,138,1484035200"; d="scan'208";a="1105452030" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2017 19:29:37 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 19:29:37 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 9 Feb 2017 19:29:36 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Fri, 10 Feb 2017 11:29:35 +0800 From: "Gao, Liming" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , Laszlo Ersek Thread-Topic: [edk2] [PATCH 02/12] MdePkg/SmiHandlerProfileLibNull: Add NULL instance. Thread-Index: AQHSgii3flRHBhFSQkWblBNrrW1+5KFhlyJA Date: Fri, 10 Feb 2017 03:29:34 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D998B@shsmsx102.ccr.corp.intel.com> References: <1486571434-20000-1-git-send-email-jiewen.yao@intel.com> <1486571434-20000-3-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1486571434-20000-3-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 02/12] MdePkg/SmiHandlerProfileLibNull: Add NULL instance. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 03:29:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable One minor comment. This library type is DXE_SMM_DRIVER. It should include <= PiSmm.h>, not =20 With this change, Reviewed-by: Liming Gao . >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Jiewen Yao >Sent: Thursday, February 09, 2017 12:30 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Laszlo Ersek >; Gao, Liming >Subject: [edk2] [PATCH 02/12] MdePkg/SmiHandlerProfileLibNull: Add NULL >instance. > >Cc: Michael D Kinney >Cc: Liming Gao >Cc: Laszlo Ersek >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Jiewen Yao >--- > MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.c | 72 >++++++++++++++++++++ > MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.inf | 36 >++++++++++ > MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.uni | 21 >++++++ > 3 files changed, 129 insertions(+) > >diff --git >a/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.c >b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.c >new file mode 100644 >index 0000000..207482a >--- /dev/null >+++ b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.c >@@ -0,0 +1,72 @@ >+/** @file >+ NULL instance of SmiHandlerProfile Library. >+ >+ Copyright (c) 2017, Intel Corporation. All rights reserved.
>+ This program and the accompanying materials >+ are licensed and made available under the terms and conditions of the B= SD >License >+ which accompanies this distribution. The full text of the license may = be >found at >+ http://opensource.org/licenses/bsd-license.php. >+ >+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" >BASIS, >+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. >+ >+**/ >+ >+#include >+#include >+ >+/** >+ This function is called by SmmChildDispatcher module to report >+ a new SMI handler is registered, to SmmCore. >+ >+ @param HandlerGuid The GUID to identify the type of the handler. >+ For the SmmChildDispatch protocol, the HandlerGu= id >+ must be the GUID of SmmChildDispatch protocol. >+ @param Handler The SMI handler. >+ @param CallerAddress The address of the module who registers the SMI >handler. >+ @param Context The context of the SMI handler. >+ For the SmmChildDispatch protocol, the Context >+ must match the one defined for SmmChildDispatch = protocol. >+ @param ContextSize The size of the context in bytes. >+ For the SmmChildDispatch protocol, the Context >+ must match the one defined for SmmChildDispatch = protocol. >+ >+ @retval EFI_SUCCESS The information is recorded. >+ @retval EFI_UNSUPPORTED The feature is unsupported. >+ @retval EFI_OUT_OF_RESOURCES There is no enough resource to record >the information. >+**/ >+EFI_STATUS >+EFIAPI >+SmiHandlerProfileRegisterHandler ( >+ IN EFI_GUID *HandlerGuid, >+ IN EFI_SMM_HANDLER_ENTRY_POINT2 Handler, >+ IN PHYSICAL_ADDRESS CallerAddress, >+ IN VOID *Context, OPTIONAL >+ IN UINTN ContextSize OPTIONAL >+ ) >+{ >+ return EFI_UNSUPPORTED; >+} >+ >+/** >+ This function is called by SmmChildDispatcher module to report >+ an existing SMI handler is unregistered, to SmmCore. >+ >+ @param HandlerGuid The GUID to identify the type of the handler. >+ For the SmmChildDispatch protocol, the HandlerGu= id >+ must be the GUID of SmmChildDispatch protocol. >+ @param Handler The SMI handler. >+ >+ @retval EFI_SUCCESS The original record is removed. >+ @retval EFI_UNSUPPORTED The feature is unsupported. >+ @retval EFI_NOT_FOUND There is no record for the HandlerGuid an= d >handler. >+**/ >+EFI_STATUS >+EFIAPI >+SmiHandlerProfileUnregisterHandler ( >+ IN EFI_GUID *HandlerGuid, >+ IN EFI_SMM_HANDLER_ENTRY_POINT2 Handler >+ ) >+{ >+ return EFI_UNSUPPORTED; >+} >diff --git >a/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.inf >b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.inf >new file mode 100644 >index 0000000..8220834 >--- /dev/null >+++ b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.inf >@@ -0,0 +1,36 @@ >+## @file >+# NULL instance of SmiHandlerProfile Library. >+# >+# Copyright (c) 2017, Intel Corporation. All rights reserved.
>+# >+# This program and the accompanying materials >+# are licensed and made available under the terms and conditions of the >BSD License >+# which accompanies this distribution. The full text of the license may = be >found at >+# http://opensource.org/licenses/bsd-license.php. >+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" >BASIS, >+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. >+# >+# >+## >+ >+[Defines] >+ INF_VERSION =3D 0x00010005 >+ BASE_NAME =3D SmiHandlerProfileLibNull >+ MODULE_UNI_FILE =3D SmiHandlerProfileLibNull.uni >+ FILE_GUID =3D B43D1B52-6251-4E6F-82EC-A599A5EE94C1 >+ MODULE_TYPE =3D DXE_SMM_DRIVER >+ VERSION_STRING =3D 1.0 >+ LIBRARY_CLASS =3D SmiHandlerProfileLib|DXE_SMM_DRIVER >SMM_CORE >+ >+# >+# The following information is for reference only and not required by the >build tools. >+# >+# VALID_ARCHITECTURES =3D IA32 X64 IPF EBC >+# >+ >+[Sources] >+ SmiHandlerProfileLibNull.c >+ >+[Packages] >+ MdePkg/MdePkg.dec >+ >diff --git >a/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.uni >b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.uni >new file mode 100644 >index 0000000..fa3ba63 >--- /dev/null >+++ b/MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.uni >@@ -0,0 +1,21 @@ >+// /** @file >+// NULL instance of SmiHandlerProfile Library. >+// >+// NULL instance of SmiHandlerProfile Library. >+// >+// Copyright (c) 2017, Intel Corporation. All rights reserved.
>+// >+// This program and the accompanying materials >+// are licensed and made available under the terms and conditions of the >BSD License >+// which accompanies this distribution. The full text of the license may = be >found at >+// http://opensource.org/licenses/bsd-license.php. >+// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" >BASIS, >+// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. >+// >+// **/ >+ >+ >+#string STR_MODULE_ABSTRACT #language en-US "NULL instance of >SmiHandlerProfile Library" >+ >+#string STR_MODULE_DESCRIPTION #language en-US "NULL instance of >SmiHandlerProfile Library." >+ >-- >2.7.4.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel