From: "Gao, Liming" <liming.gao@intel.com>
To: Andrew Fish <afish@apple.com>, edk2-devel <edk2-devel@lists.01.org>
Subject: Re: Should we add PCI VenderId defines to the PCI Includes in the MdePkg.
Date: Fri, 10 Feb 2017 04:59:09 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D9A29@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <734C28CD-1707-4053-89B8-3747FEB7017D@apple.com>
Andrew:
I agree with you. Could you help submit the tracker in bugzilla for this request?
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Andrew Fish
>Sent: Friday, February 10, 2017 11:31 AM
>To: edk2-devel <edk2-devel@lists.01.org>
>Subject: [edk2] Should we add PCI VenderId defines to the PCI Includes in the
>MdePkg.
>
>Some one was asking me why the PCI VendorIds are not included in the
>MdePkg and my answer was it seems like a good idea to me.
>
>We don't have to go crazy as we only really need the VendorIds for vendors
>who make things that EFI deals with. It is probably easy enough to get an initial
>list, and then just add values on request.
>
>Looks like a bit of duplication is already in the tree...
>
>(master)>git grep -w 0x8086 -- *.h *.c
>AppPkg/Applications/Python/Python-2.7.10/Objects/unicodetype_db.h:2636:
>case 0x8086:
>AppPkg/Applications/Python/Python-2.7.2/Objects/unicodetype_db.h:2636:
>case 0x8086:
>CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c:50
>2: (Pci->Hdr.VendorId == 0x8086)
>DuetPkg/Library/DuetBdsLib/BdsPlatform.c:857: ((IS_PCI_ISA_PDECODE
>(&Pci)) && (Pci.Hdr.VendorId == 0x8086) && (Pci.Hdr.DeviceId == 0x7110))) {
>DuetPkg/PciBusNoEnumerationDxe/PciBus.h:222:#define
>IS_INTEL_ISA_BRIDGE(_p) (IS_CLASS2 (_p, PCI_CLASS_BRIDGE,
>PCI_CLASS_BRIDGE_ISA_PDECODE) && ((_p)->Hdr.VendorId == 0x8086) &&
>((_p)->Hdr.DeviceId == 0x7110))
>OptionRomPkg/UndiRuntimeDxe/E100b.h:23:#define PCI_VENDOR_ID_INTEL
>0x8086
>OptionRomPkg/UndiRuntimeDxe/E100b.h:25:#define D100_VENDOR_ID
>0x8086
>OptionRomPkg/UndiRuntimeDxe/Init.c:113: than contains a DevicePath,
>PciIo protocol, Class code of 2, Vendor ID of 0x8086,
>OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c:72: 0x8086, // UINT16
>CompatibleVid
>OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.h:50:#define
>V_INTEL_VENDOR_ID 0x8086
>OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c:848: (Pci-
>>Hdr.VendorId == 0x8086) &&
>PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c:118: Pci.Hdr.VendorId ==
>0x8086 ) {
>QuarkPlatformPkg/Feature/Capsule/Library/PlatformFlashAccessLib/SpiFlash
>Device.h:181:#define PFAB_CARD_VENDOR_ID 0x8086
>QuarkPlatformPkg/Platform/SpiFvbServices/SpiFlashDevice.h:182:#define
>PFAB_CARD_VENDOR_ID 0x8086
>QuarkSocPkg/QuarkNorthCluster/Include/QuarkNcSocId.h:363:#define
>V_INTEL_VENDOR_ID 0x8086
>QuarkSocPkg/QuarkSouthCluster/Include/Ioh.h:69:#define
>INTEL_VENDOR_ID 0x8086 // Intel Vendor ID
>Vlv2DeviceRefCodePkg/ValleyView2Soc/NorthCluster/Include/Valleyview.h:3
>9:#define MC_VID 0x8086
>Vlv2DeviceRefCodePkg/ValleyView2Soc/NorthCluster/Include/Valleyview.h:5
>2:#define IGD_VID 0x8086
>Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/PchRegs.h:119
>:#define V_PCH_INTEL_VENDOR_ID 0x8086
>Vlv2TbltDevicePkg/Include/CommonIncludes.h:24:#define V_INTEL_VID
>0x8086
>Vlv2TbltDevicePkg/Include/Platform.h:136:#define
>V_DEFAULT_SUBSYSTEM_VENDOR_ID 0x8086
>Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:2
>4:#define SUBSYSTEM_VENDOR_ID1 0x8086
>Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:2
>8:#define SUBSYSTEM_VENDOR_ID2 0x8086
>Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardSsidSvid/BoardSsidSvid.h:3
>2:#define SUBSYSTEM_VENDOR_ID 0x8086
>Vlv2TbltDevicePkg/PciPlatform/BoardPciPlatform.c:30:#define
>V_INTEL_LAN_VENDOR_ID 0x8086 // INTEL 82574 Gbe Controller
>Vendor ID
>Vlv2TbltDevicePkg/PlatformDxe/PciDevice.c:42:#define INTEL_VENDOR_ID
>0x8086
>Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.h:134: UINT16 VendorId;
>// 0x8086
>Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.h:61:#define IGD_VID
>0x8086
>Vlv2TbltDevicePkg/Wpce791/LpcDriver.c:194: Pci.Hdr.VendorId ==
>0x8086 &&
>
>
>Thanks,
>
>Andrew Fish
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-02-10 4:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 3:31 Should we add PCI VenderId defines to the PCI Includes in the MdePkg Andrew Fish
2017-02-10 4:59 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6D9A29@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox