public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 0/4] PrintLib: Add safe print functions [A|U]ValueToStringS
Date: Mon, 20 Feb 2017 02:53:28 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E0BBE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1486620170-38136-1-git-send-email-hao.a.wu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wu, Hao A
>Sent: Thursday, February 09, 2017 2:03 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
>Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [PATCH v2 0/4] PrintLib: Add safe print functions
>[A|U]ValueToStringS
>
>V2 changes:
>Add the EFI_PRINT2S_PROTOCOL as a safe version of the
>EFI_PRINT2_PROTOCOL,
>the new protocol replaces the following 2 services in EFI_PRINT2_PROTOCOL:
>UNICODE_VALUE_TO_STRING
>ASCII_VALUE_TO_STRING
>with:
>UNICODE_VALUE_TO_STRING_S
>ASCII_VALUE_TO_STRING_S
>
>Now, the PrintLib instance MdeModulePkg/Library/DxePrintLibPrint2Protocol
>will use EFI_PRINT2S_PROTOCOL instead of EFI_PRINT2_PROTOCOL to
>implement
>its APIs.
>
>
>V1 history:
>Add the following 2 safe print functions in PrintLib:
>UnicodeValueToStringS
>AsciiValueToStringS
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>
>
>Hao Wu (4):
>  MdePkg/BasePrintLib: Add safe print functions [A|U]ValueToStringS
>  MdeModulePkg: Add the EFI_PRINT2S_PROTOCOL
>  MdeModulePkg/PrintLib: Use EFI_PRINT2S_PROTOCOL for this instance
>  MdeModulePkg/PrintLib: Add safe print functions [A|U]ValueToStringS
>
> MdeModulePkg/Include/Protocol/Print2.h                                       | 150
>+++++++++++++-
>
>MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.
>inf |   4 +-
>
>MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.
>uni |  10 +-
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c                    | 183
>++++++++++++++++--
> MdeModulePkg/MdeModulePkg.dec                                                |   3 +-
> MdeModulePkg/Universal/PrintDxe/Print.c                                      |  18 +-
> MdeModulePkg/Universal/PrintDxe/PrintDxe.inf                                 |   7 +-
> MdeModulePkg/Universal/PrintDxe/PrintDxe.uni                                 |  10 +-
> MdePkg/Include/Library/PrintLib.h                                            | 121
>++++++++++++
> MdePkg/Library/BasePrintLib/PrintLib.c                                       | 128
>++++++++++++
> MdePkg/Library/BasePrintLib/PrintLibInternal.c                               | 204
>++++++++++++++++++++
> MdePkg/Library/BasePrintLib/PrintLibInternal.h                               |  61 ++++++
> 12 files changed, 865 insertions(+), 34 deletions(-)
>
>--
>1.9.5.msysgit.0



      parent reply	other threads:[~2017-02-20  2:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09  6:02 [PATCH v2 0/4] PrintLib: Add safe print functions [A|U]ValueToStringS Hao Wu
2017-02-09  6:02 ` [PATCH v2 1/4] MdePkg/BasePrintLib: " Hao Wu
2017-02-09  6:02 ` [PATCH v2 2/4] MdeModulePkg: Add the EFI_PRINT2S_PROTOCOL Hao Wu
2017-02-09  6:02 ` [PATCH v2 3/4] MdeModulePkg/PrintLib: Use EFI_PRINT2S_PROTOCOL for this instance Hao Wu
2017-02-09  6:02 ` [PATCH v2 4/4] MdeModulePkg/PrintLib: Add safe print functions [A|U]ValueToStringS Hao Wu
2017-02-20  2:53 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6E0BBE@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox