From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib
Date: Tue, 28 Feb 2017 03:23:23 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E5652@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170227072239.273228-1-ruiyu.ni@intel.com>
The change in MdePkg are good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Ruiyu Ni
>Sent: Monday, February 27, 2017 3:22 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in
>BaseLib
>
>The patch set adds StrToGuid/StrHexToBytes/StrToIPv4Address
>/StrToIPv6Address and the accordingly ASCII versioins to BaseLib.
>It also changes all existing consumers to use the new APIs.
>
>v2: Return UNSUPPORTED for cases when the string is malformatted.
> Update consumer code to use RETURN_STATUS receive the returned
> status instead of embedding the function call in RETURN_ERROR().
>
>Ruiyu Ni (11):
> MdePkg: Define IPv4_ADDRESS and IPv6_ADDRESS in Base.h
> MdePkg/UefiDevicePathLib: Rename StrToGuid to avoid link failure
> SignedCapsulePkg/IniParsing: Rename StrToGuid to avoid link failure
> MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address
> MdePkg/BaseLib: Add AsciiStrToGuid/HexToBytes/ToIpv[4/6]Address
> MdePkg/UefiDevicePathLib: Use BaseLib string conversion services
> MdeModulePkg/CapsuleApp: Use StrToGuid in BaseLib
> SecurityPkg/SecureBootConfigDxe: Use StrToGuid in BaseLib
> ShellPkg/Debug1CommandLib: Use StrToGuid/StrHexToBytes in BaseLib
> SignedCapsulePkg/IniParsingLib: Use AsciiStrToGuid in BaseLib
> MdeModulePkg/NetLib: Use StrToIpv4/6Address in BaseLib
>
> MdeModulePkg/Application/CapsuleApp/AppSupport.c | 140 +--
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 27 +-
> MdeModulePkg/Include/Library/NetLib.h | 5 +-
> MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 382 +------
> MdePkg/Include/Base.h | 16 +-
> MdePkg/Include/Library/BaseLib.h | 445 ++++++++
> MdePkg/Include/Uefi/UefiBaseType.h | 10 +-
> MdePkg/Library/BaseLib/SafeString.c | 1204
>++++++++++++++++++++
> .../Library/UefiDevicePathLib/DevicePathFromText.c | 213 +---
> .../SecureBootConfigDxe/SecureBootConfigImpl.c | 12 +-
> .../SecureBootConfigDxe/SecureBootConfigImpl.h | 22 +-
> .../SecureBootConfigDxe/SecureBootConfigMisc.c | 141 +--
> .../Library/UefiShellDebug1CommandsLib/DmpStore.c | 7 +-
> .../Library/UefiShellDebug1CommandsLib/SetVar.c | 12 +-
> .../UefiShellDebug1CommandsLib.c | 119 +-
> .../UefiShellDebug1CommandsLib.h | 32 +-
> .../Library/IniParsingLib/IniParsingLib.c | 148 +--
> 17 files changed, 1740 insertions(+), 1195 deletions(-)
>
>--
>2.9.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-02-28 3:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 7:22 [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 01/11] MdePkg: Define IPv4_ADDRESS and IPv6_ADDRESS in Base.h Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 02/11] MdePkg/UefiDevicePathLib: Rename StrToGuid to avoid link failure Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 03/11] SignedCapsulePkg/IniParsing: " Ruiyu Ni
2017-02-27 7:51 ` Yao, Jiewen
2017-02-27 7:22 ` [PATCH v2 04/11] MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address Ruiyu Ni
2017-02-28 5:23 ` Fu, Siyuan
2017-02-27 7:22 ` [PATCH v2 05/11] MdePkg/BaseLib: Add AsciiStrToGuid/HexToBytes/ToIpv[4/6]Address Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 06/11] MdePkg/UefiDevicePathLib: Use BaseLib string conversion services Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 07/11] MdeModulePkg/CapsuleApp: Use StrToGuid in BaseLib Ruiyu Ni
2017-02-27 7:50 ` Yao, Jiewen
2017-02-27 7:22 ` [PATCH v2 08/11] SecurityPkg/SecureBootConfigDxe: " Ruiyu Ni
2017-02-27 7:22 ` [PATCH v2 09/11] ShellPkg/Debug1CommandLib: Use StrToGuid/StrHexToBytes " Ruiyu Ni
2017-02-28 17:05 ` Carsey, Jaben
2017-02-27 7:22 ` [PATCH v2 10/11] SignedCapsulePkg/IniParsingLib: Use AsciiStrToGuid " Ruiyu Ni
2017-02-27 7:50 ` Yao, Jiewen
2017-02-27 7:22 ` [PATCH v2 11/11] MdeModulePkg/NetLib: Use StrToIpv4/6Address " Ruiyu Ni
2017-02-28 3:23 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6E5652@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox