From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6FAD881EE0 for ; Mon, 27 Feb 2017 19:23:27 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 19:23:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,217,1484035200"; d="scan'208";a="1103016442" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 27 Feb 2017 19:23:26 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 27 Feb 2017 19:23:26 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 27 Feb 2017 19:23:26 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Tue, 28 Feb 2017 11:23:24 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib Thread-Index: AQHSkMpOGr+pfW2jwEK4ZZoy7kmM0KF9wjTw Date: Tue, 28 Feb 2017 03:23:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E5652@shsmsx102.ccr.corp.intel.com> References: <20170227072239.273228-1-ruiyu.ni@intel.com> In-Reply-To: <20170227072239.273228-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 03:23:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change in MdePkg are good to me. Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Ruiyu Ni >Sent: Monday, February 27, 2017 3:22 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in >BaseLib > >The patch set adds StrToGuid/StrHexToBytes/StrToIPv4Address >/StrToIPv6Address and the accordingly ASCII versioins to BaseLib. >It also changes all existing consumers to use the new APIs. > >v2: Return UNSUPPORTED for cases when the string is malformatted. > Update consumer code to use RETURN_STATUS receive the returned > status instead of embedding the function call in RETURN_ERROR(). > >Ruiyu Ni (11): > MdePkg: Define IPv4_ADDRESS and IPv6_ADDRESS in Base.h > MdePkg/UefiDevicePathLib: Rename StrToGuid to avoid link failure > SignedCapsulePkg/IniParsing: Rename StrToGuid to avoid link failure > MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address > MdePkg/BaseLib: Add AsciiStrToGuid/HexToBytes/ToIpv[4/6]Address > MdePkg/UefiDevicePathLib: Use BaseLib string conversion services > MdeModulePkg/CapsuleApp: Use StrToGuid in BaseLib > SecurityPkg/SecureBootConfigDxe: Use StrToGuid in BaseLib > ShellPkg/Debug1CommandLib: Use StrToGuid/StrHexToBytes in BaseLib > SignedCapsulePkg/IniParsingLib: Use AsciiStrToGuid in BaseLib > MdeModulePkg/NetLib: Use StrToIpv4/6Address in BaseLib > > MdeModulePkg/Application/CapsuleApp/AppSupport.c | 140 +-- > MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 27 +- > MdeModulePkg/Include/Library/NetLib.h | 5 +- > MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 382 +------ > MdePkg/Include/Base.h | 16 +- > MdePkg/Include/Library/BaseLib.h | 445 ++++++++ > MdePkg/Include/Uefi/UefiBaseType.h | 10 +- > MdePkg/Library/BaseLib/SafeString.c | 1204 >++++++++++++++++++++ > .../Library/UefiDevicePathLib/DevicePathFromText.c | 213 +--- > .../SecureBootConfigDxe/SecureBootConfigImpl.c | 12 +- > .../SecureBootConfigDxe/SecureBootConfigImpl.h | 22 +- > .../SecureBootConfigDxe/SecureBootConfigMisc.c | 141 +-- > .../Library/UefiShellDebug1CommandsLib/DmpStore.c | 7 +- > .../Library/UefiShellDebug1CommandsLib/SetVar.c | 12 +- > .../UefiShellDebug1CommandsLib.c | 119 +- > .../UefiShellDebug1CommandsLib.h | 32 +- > .../Library/IniParsingLib/IniParsingLib.c | 148 +-- > 17 files changed, 1740 insertions(+), 1195 deletions(-) > >-- >2.9.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel