From: "Gao, Liming" <liming.gao@intel.com>
To: "Marvin.Haeuser@outlook.com" <Marvin.Haeuser@outlook.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds
Date: Mon, 6 Mar 2017 02:27:15 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E8472@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <AM5PR0601MB257910AE367C5FF494AD751E802D0@AM5PR0601MB2579.eurprd06.prod.outlook.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
>Sent: Sunday, March 05, 2017 11:00 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong
><yonghong.zhu@intel.com>
>Subject: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on
>RELEASE builds
>
>Set -Wno-unused-but-set-variable on RELEASE builds so variables only
>verified in DEBUG code (e.g. ASSERT()) do not trigger build errors.
>This is done to align with GCC compilation:
>https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891d8
>b59a1553cd83
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
>---
> BaseTools/Conf/tools_def.template | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/BaseTools/Conf/tools_def.template
>b/BaseTools/Conf/tools_def.template
>index ab4f936e7a8b..b9a063215354 100755
>--- a/BaseTools/Conf/tools_def.template
>+++ b/BaseTools/Conf/tools_def.template
>@@ -5467,7 +5467,7 @@ DEFINE CLANG35_AARCH64_CC_FLAGS =
>DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64
> *_CLANG35_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS)
>
> DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS)
>$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
>-RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS)
>$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz
>+RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS)
>$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz -Wno-unused-but-set-variable
>
> ##################
> # CLANG35 AARCH64 definitions
>@@ -5489,7 +5489,7 @@ RELEASE_CLANG35_ARM_CC_FLAGS =
>DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P
> *_CLANG35_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS)
>
> DEBUG_CLANG35_AARCH64_CC_FLAGS =
>DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
>-O0
>-RELEASE_CLANG35_AARCH64_CC_FLAGS =
>DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
>-Oz -fomit-frame-pointer
>+RELEASE_CLANG35_AARCH64_CC_FLAGS =
>DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
>-Oz -fomit-frame-pointer -Wno-unused-but-set-variable
>
>
>###########################################################
>#########################
> #
>@@ -5543,7 +5543,7 @@ DEBUG_CLANG38_IA32_CC_FLAGS =
>DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -
> DEBUG_CLANG38_IA32_DLINK_FLAGS =
>DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,--
>oformat=elf32-i386
> DEBUG_CLANG38_IA32_DLINK2_FLAGS = DEF(GCC5_IA32_DLINK2_FLAGS)
>-O3
>
>-RELEASE_CLANG38_IA32_CC_FLAGS = DEF(CLANG38_ALL_CC_FLAGS) -
>m32 -Oz -flto -march=i586 DEF(CLANG38_IA32_TARGET)
>+RELEASE_CLANG38_IA32_CC_FLAGS = DEF(CLANG38_ALL_CC_FLAGS) -
>m32 -Oz -flto -march=i586 DEF(CLANG38_IA32_TARGET) -Wno-unused-but-
>set-variable
> RELEASE_CLANG38_IA32_DLINK_FLAGS =
>DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,--
>oformat=elf32-i386
> RELEASE_CLANG38_IA32_DLINK2_FLAGS = DEF(GCC5_IA32_DLINK2_FLAGS)
>-O3
>
>@@ -5580,7 +5580,7 @@ DEBUG_CLANG38_X64_CC_FLAGS =
>DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
> DEBUG_CLANG38_X64_DLINK_FLAGS =
>DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,--
>oformat=elf64-x86-64 -Wl,-pie -mcmodel=small
> DEBUG_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) -
>O3
>
>-RELEASE_CLANG38_X64_CC_FLAGS = DEF(CLANG38_ALL_CC_FLAGS) -
>m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -
>fpie -Oz -flto DEF(CLANG38_X64_TARGET)
>+RELEASE_CLANG38_X64_CC_FLAGS = DEF(CLANG38_ALL_CC_FLAGS) -
>m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -
>fpie -Oz -flto DEF(CLANG38_X64_TARGET) -Wno-unused-but-set-variable
> RELEASE_CLANG38_X64_DLINK_FLAGS =
>DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,--
>oformat=elf64-x86-64 -Wl,-pie -mcmodel=small
> RELEASE_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) -
>O3
>
>--
>2.11.1.windows.1
next prev parent reply other threads:[~2017-03-06 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 3:00 [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds Marvin Häuser
2017-03-06 2:27 ` Gao, Liming [this message]
2017-03-07 1:55 ` Marvin Häuser
2017-03-07 3:04 ` Marvin Häuser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6E8472@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox