From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg/Pci22.h: Remove deprecated macros
Date: Fri, 10 Mar 2017 00:39:19 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6EDFE2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170306063934.600524-1-ruiyu.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
> Sent: Monday, March 6, 2017 2:40 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] MdePkg/Pci22.h: Remove deprecated macros
>
> The following deprecated macros are removed.The removal
> doesn't cause any build failure to existing packages.
>
> #define DEVICE_ID_NOCARE 0xFFFF
> #define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL
> #define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL
> #define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL
> #define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL
> #define PCI_BAR_ALL 0xFF
> #define PCI_ACPI_UNUSED 0
> #define PCI_BAR_NOCHANGE 0
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Pci22.h | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h b/MdePkg/Include/IndustryStandard/Pci22.h
> index 07718dc..96a7680 100644
> --- a/MdePkg/Include/IndustryStandard/Pci22.h
> +++ b/MdePkg/Include/IndustryStandard/Pci22.h
> @@ -780,25 +780,6 @@ typedef struct {
> ///
> } EFI_PCI_CAPABILITY_HOTPLUG;
>
> -///
> -/// Below macros (till PCI_BAR_NOCHANGE) were used by EfiIncompatiblePciDeviceSupport Protocol.
> -///
> -#ifndef DISABLE_NEW_DEPRECATED_INTERFACES
> -
> -///
> -/// [ATTENTION] These macros are deprecated because they don't match Spec or not defined in Spec.
> -///
> -#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't match Spec.
> -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't match Spec.
> -#define PCI_ACPI_UNUSED 0 ///< Deprecated. Macro name is too general.
> -#define PCI_BAR_NOCHANGE 0 ///< Deprecated. Macro name is too general.
> -
> -#endif
> -
> #define PCI_BAR_IDX0 0x00
> #define PCI_BAR_IDX1 0x01
> #define PCI_BAR_IDX2 0x02
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-03-10 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 6:39 [PATCH] MdePkg/Pci22.h: Remove deprecated macros Ruiyu Ni
2017-03-10 0:39 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D6EDFE2@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox