* [PATCH] MdePkg/Pci22.h: Remove deprecated macros
@ 2017-03-06 6:39 Ruiyu Ni
2017-03-10 0:39 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2017-03-06 6:39 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao
The following deprecated macros are removed.The removal
doesn't cause any build failure to existing packages.
#define DEVICE_ID_NOCARE 0xFFFF
#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL
#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL
#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL
#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL
#define PCI_BAR_ALL 0xFF
#define PCI_ACPI_UNUSED 0
#define PCI_BAR_NOCHANGE 0
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
MdePkg/Include/IndustryStandard/Pci22.h | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Pci22.h b/MdePkg/Include/IndustryStandard/Pci22.h
index 07718dc..96a7680 100644
--- a/MdePkg/Include/IndustryStandard/Pci22.h
+++ b/MdePkg/Include/IndustryStandard/Pci22.h
@@ -780,25 +780,6 @@ typedef struct {
///
} EFI_PCI_CAPABILITY_HOTPLUG;
-///
-/// Below macros (till PCI_BAR_NOCHANGE) were used by EfiIncompatiblePciDeviceSupport Protocol.
-///
-#ifndef DISABLE_NEW_DEPRECATED_INTERFACES
-
-///
-/// [ATTENTION] These macros are deprecated because they don't match Spec or not defined in Spec.
-///
-#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't match Spec.
-#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. Value isn't defined in Spec.
-#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. Value isn't defined in Spec.
-#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. Value isn't defined in Spec.
-#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. Value isn't defined in Spec.
-#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't match Spec.
-#define PCI_ACPI_UNUSED 0 ///< Deprecated. Macro name is too general.
-#define PCI_BAR_NOCHANGE 0 ///< Deprecated. Macro name is too general.
-
-#endif
-
#define PCI_BAR_IDX0 0x00
#define PCI_BAR_IDX1 0x01
#define PCI_BAR_IDX2 0x02
--
2.9.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MdePkg/Pci22.h: Remove deprecated macros
2017-03-06 6:39 [PATCH] MdePkg/Pci22.h: Remove deprecated macros Ruiyu Ni
@ 2017-03-10 0:39 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-03-10 0:39 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
> Sent: Monday, March 6, 2017 2:40 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] MdePkg/Pci22.h: Remove deprecated macros
>
> The following deprecated macros are removed.The removal
> doesn't cause any build failure to existing packages.
>
> #define DEVICE_ID_NOCARE 0xFFFF
> #define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL
> #define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL
> #define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL
> #define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL
> #define PCI_BAR_ALL 0xFF
> #define PCI_ACPI_UNUSED 0
> #define PCI_BAR_NOCHANGE 0
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Pci22.h | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h b/MdePkg/Include/IndustryStandard/Pci22.h
> index 07718dc..96a7680 100644
> --- a/MdePkg/Include/IndustryStandard/Pci22.h
> +++ b/MdePkg/Include/IndustryStandard/Pci22.h
> @@ -780,25 +780,6 @@ typedef struct {
> ///
> } EFI_PCI_CAPABILITY_HOTPLUG;
>
> -///
> -/// Below macros (till PCI_BAR_NOCHANGE) were used by EfiIncompatiblePciDeviceSupport Protocol.
> -///
> -#ifndef DISABLE_NEW_DEPRECATED_INTERFACES
> -
> -///
> -/// [ATTENTION] These macros are deprecated because they don't match Spec or not defined in Spec.
> -///
> -#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't match Spec.
> -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. Value isn't defined in Spec.
> -#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't match Spec.
> -#define PCI_ACPI_UNUSED 0 ///< Deprecated. Macro name is too general.
> -#define PCI_BAR_NOCHANGE 0 ///< Deprecated. Macro name is too general.
> -
> -#endif
> -
> #define PCI_BAR_IDX0 0x00
> #define PCI_BAR_IDX1 0x01
> #define PCI_BAR_IDX2 0x02
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-10 0:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-06 6:39 [PATCH] MdePkg/Pci22.h: Remove deprecated macros Ruiyu Ni
2017-03-10 0:39 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox