From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5721D8028E for ; Tue, 14 Mar 2017 06:06:22 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 14 Mar 2017 06:06:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,163,1486454400"; d="scan'208";a="1122353955" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 14 Mar 2017 06:06:21 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Mar 2017 06:06:21 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Mar 2017 06:06:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Tue, 14 Mar 2017 21:06:18 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Dong, Eric" Thread-Topic: [edk2] [patch] MdePkg/HiiImageEx: Fix incorrect comments of functions Thread-Index: AQHSnGPUA2auwbrJwkyUbNhJeO8LAqGTvGiQ//+KI4CAAQgKsA== Date: Tue, 14 Mar 2017 13:06:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6EFA0F@shsmsx102.ccr.corp.intel.com> References: <1489455554-94000-1-git-send-email-dandan.bi@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6EF767@shsmsx102.ccr.corp.intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3B89B4C8@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3B89B4C8@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdePkg/HiiImageEx: Fix incorrect comments of functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 13:06:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's good. The change is good to me. > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, March 14, 2017 1:21 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric > Subject: RE: [edk2] [patch] MdePkg/HiiImageEx: Fix incorrect comments of = functions >=20 > Hi Liming, >=20 > It seems no need to change the comments in the implementation codes. > The comments in the implementation codes are correct. >=20 >=20 > Thanks, > Dandan > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, March 14, 2017 12:23 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric > Subject: RE: [edk2] [patch] MdePkg/HiiImageEx: Fix incorrect comments of = functions >=20 > Dandan: > Is this change required in HiiDataBase? HiiDataBase implements HiiImage= Ex protocol. >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Dandan Bi > > Sent: Tuesday, March 14, 2017 9:39 AM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Dong, Eric ; > > Gao, Liming > > Subject: [edk2] [patch] MdePkg/HiiImageEx: Fix incorrect comments of > > functions > > > > Cc: Liming Gao > > Cc: Ruiyu Ni > > Cc: Eric Dong > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Dandan Bi > > --- > > MdePkg/Include/Protocol/HiiImageEx.h | 80 > > +++++++++++++++++++----------------- > > 1 file changed, 43 insertions(+), 37 deletions(-) > > > > diff --git a/MdePkg/Include/Protocol/HiiImageEx.h > > b/MdePkg/Include/Protocol/HiiImageEx.h > > index b92fc3a..5a48380 100644 > > --- a/MdePkg/Include/Protocol/HiiImageEx.h > > +++ b/MdePkg/Include/Protocol/HiiImageEx.h > > @@ -26,12 +26,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, = EITHER EXPRESS OR IMPLIED. > > > > typedef struct _EFI_HII_IMAGE_EX_PROTOCOL EFI_HII_IMAGE_EX_PROTOCOL; > > > > /** > > The prototype of this extension function is the same with EFI_HII_IM= AGE_PROTOCOL.NewImage(). > > - Same with EFI_HII_IMAGE_PROTOCOL.NewImage().This protocol invokes > > -EFI_HII_IMAGE_PROTOCOL.NewImage() implicitly. > > + This protocol invokes EFI_HII_IMAGE_PROTOCOL.NewImage() implicitly. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > @param PackageList Handle of the package list where this= image will > > be added. > > @param ImageId On return, contains the new image id,= which is > > @@ -55,26 +54,28 @@ EFI_STATUS > > ); > > > > /** > > Return the information about the image, associated with the package = list. > > The prototype of this extension function is the same with EFI_HII_IM= AGE_PROTOCOL.GetImage(). > > - Same with EFI_HII_IMAGE_PROTOCOL.SetImage(),this protocol invokes EF= I_HII_IMAGE_PROTOCOL.SetImage() implicitly. > > + > > + This function is similar to EFI_HII_IMAGE_PROTOCOL.GetImage().The > > + difference is that this function will locate all > > + EFI_HII_IMAGE_DECODER_PROTOCOL instances installed in the system if > > + the decoder of the certain image type is not supported by the > > + EFI_HII_IMAGE_EX_PROTOCOL. The function will attempt to decode the > > + image to the EFI_IMAGE_INPUT using the first EFI_HII_IMAGE_DECODER_P= ROTOCOL instance that supports the requested > image type. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > - @param PackageList Handle of the package list where this= image will > > - be searched. > > - @param ImageId The image's id,, which is unique with= in > > - PackageList. > > + @param PackageList The package list in the HII database = to search for the > > + specified image. > > + @param ImageId The image's id, which is unique withi= n PackageList. > > @param Image Points to the image. > > > > @retval EFI_SUCCESS The new image was returned successful= ly. > > - @retval EFI_NOT_FOUND The image specified by ImageId is not= in the > > - database. The specified PackageList i= s not in > > - the database. > > - @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is = too small to > > - hold the image. > > - @retval EFI_INVALID_PARAMETER The Image or ImageSize was NULL. > > + @retval EFI_NOT_FOUND The image specified by ImageId is not= available. The specified > > + PackageList is not in the Database. > > + @retval EFI_INVALID_PARAMETER Image was NULL or ImageId was 0. > > @retval EFI_OUT_OF_RESOURCES The bitmap could not be retrieved bec= ause there > > was not enough memory. > > > > **/ > > typedef > > @@ -85,25 +86,26 @@ EFI_STATUS > > IN EFI_IMAGE_ID ImageId, > > OUT EFI_IMAGE_INPUT *Image > > ); > > > > /** > > - Change the information about the image. The prototype of this > > extension > > - function is the same with EFI_HII_IMAGE_PROTOCOL.SetImage(). Same > > with > > - EFI_HII_IMAGE_PROTOCOL.DrawImageId(),this protocol invokes EFI_HII_I= MAGE_PROTOCOL.DrawImageId() implicitly. > > + Change the information about the image. > > + > > + Same with EFI_HII_IMAGE_PROTOCOL.SetImage(),this protocol invokes > > + EFI_HII_IMAGE_PROTOCOL.SetImage()implicitly. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > @param PackageList The package list containing the image= s. > > - @param ImageId The image's id,, which is unique with= in > > - PackageList. > > + @param ImageId The image's id, which is unique withi= n PackageList. > > @param Image Points to the image. > > > > - @retval EFI_SUCCESS The new image was updated successfull= y. > > + @retval EFI_SUCCESS The new image was successfully update= d. > > @retval EFI_NOT_FOUND The image specified by ImageId is not= in the > > database. The specified PackageList i= s not in > > the database. > > - @retval EFI_INVALID_PARAMETER The Image was NULL. > > + @retval EFI_INVALID_PARAMETER The Image was NULL, the ImageId was 0= or > > + the Image->Bitmap was NULL. > > > > **/ > > typedef > > EFI_STATUS > > (EFIAPI *EFI_HII_SET_IMAGE_EX)( > > @@ -112,34 +114,35 @@ EFI_STATUS > > IN EFI_IMAGE_ID ImageId, > > IN CONST EFI_IMAGE_INPUT *Image > > ); > > > > /** > > - Renders an image to a bitmap or to the display. The prototype of > > this extension > > - function is the same with EFI_HII_IMAGE_PROTOCOL.DrawImage(). > > - Same with EFI_HII_IMAGE_PROTOCOL.SetImage(),this protocol invokes EF= I_HII_IMAGE_PROTOCOL.SetImage() implicitly. > > + Renders an image to a bitmap or to the display. > > + > > + The prototype of this extension function is the same with > > + EFI_HII_IMAGE_PROTOCOL.DrawImage(). This protocol invokes > > + EFI_HII_IMAGE_PROTOCOL.DrawImage() implicitly. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > @param Flags Describes how the image is to be draw= n. > > @param Image Points to the image to be displayed. > > @param Blt If this points to a non-NULL on entry= , this points > > to the image, which is Width pixels w= ide and > > Height pixels high. The image will b= e drawn onto > > this image and EFI_HII_DRAW_FLAG_CLI= P is implied. > > - If this points to a NULL on entry, t= hen a buffer > > - will be allocated to hold the genera= ted image and > > + If this points to a NULL on entry, th= en a buffer > > + will be allocated to hold the > > + generated image and > > the pointer updated on exit. It is th= e caller's > > responsibility to free this buffer. > > @param BltX Specifies the offset from the left an= d top edge of > > - the output image of the first pixel = in the image. > > + the output image of the first pixel i= n the image. > > @param BltY Specifies the offset from the left an= d top edge of > > - the output image of the first pixel = in the image. > > + the output image of the first pixel i= n the image. > > > > @retval EFI_SUCCESS The image was successfully drawn. > > @retval EFI_OUT_OF_RESOURCES Unable to allocate an output buffer f= or Blt. > > @retval EFI_INVALID_PARAMETER The Image or Blt was NULL. > > - Any combination of Flags is invalid. > > > > **/ > > typedef > > EFI_STATUS > > (EFIAPI *EFI_HII_DRAW_IMAGE_EX)( > > @@ -151,21 +154,24 @@ EFI_STATUS > > IN UINTN BltY > > ); > > > > /** > > Renders an image to a bitmap or the screen containing the contents > > of the specified > > - image. The prototype of this extension function is the same with E > > - FI_HII_IMAGE_PROTOCOL.DrawImageId(). > > - Same with EFI_HII_IMAGE_PROTOCOL.DrawImageId(),this protocol > > invokes > > -EFI_HII_IMAGE_PROTOCOL.DrawImageId() implicitly. > > + image. > > + > > + This function is similar to EFI_HII_IMAGE_PROTOCOL.DrawImageId(). > > + The difference is that this function will locate all > > + EFI_HII_IMAGE_DECODER_PROTOCOL instances installed in the system if > > + the decoder of the certain image type is not supported by the > > + EFI_HII_IMAGE_EX_PROTOCOL. The function will attempt to decode the > > + image to the EFI_IMAGE_INPUT using the first EFI_HII_IMAGE_DECODER_P= ROTOCOL instance that supports the requested > image type. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > @param Flags Describes how the image is to be draw= n. > > @param PackageList The package list in the HII database = to search for > > the specified image. > > - @param ImageId The image's id, which is unique withi= n > > - PackageList. > > + @param ImageId The image's id, which is unique withi= n PackageList. > > @param Blt If this points to a non-NULL on entry= , this points > > to the image, which is Width pixels w= ide and > > Height pixels high. The image will be= drawn onto > > this image and EFI_HII_DRAW_FLAG_CLIP= is implied. > > If this points to a NULL on entry, > > then a buffer @@ -177,11 +183,11 @@ EFI_HII_IMAGE_PROTOCOL.DrawImageId(= ) implicitly. > > @param BltY Specifies the offset from the left an= d top edge of > > the output image of the first pixel i= n the image. > > > > @retval EFI_SUCCESS The image was successfully drawn. > > @retval EFI_OUT_OF_RESOURCES Unable to allocate an output buffer f= or Blt. > > - @retval EFI_INVALID_PARAMETER The Blt was NULL. > > + @retval EFI_INVALID_PARAMETER The Blt was NULL or ImageId was 0. > > @retval EFI_NOT_FOUND The image specified by ImageId is not= in the database. > > The specified PackageList is not in t= he database. > > > > **/ > > typedef > > @@ -204,19 +210,19 @@ EFI_STATUS > > system if the decoder of image type is not supported by the EFI_HII_= IMAGE_EX_PROTOCOL. > > > > @param This A pointer to the EFI_HII_IMAGE_EX_PRO= TOCOL instance. > > @param PackageList Handle of the package list where this= image will > > be searched. > > - @param ImageId The image's id,, which is unique with= in PackageList. > > + @param ImageId The image's id, which is unique withi= n PackageList. > > @param Image Points to the image. > > > > @retval EFI_SUCCESS The new image was returned successful= ly. > > @retval EFI_NOT_FOUND The image specified by ImageId is not= in the > > database. The specified PackageList i= s not in the database. > > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is = too small to > > hold the image. > > - @retval EFI_INVALID_PARAMETER The Image or ImageSize was NULL. > > + @retval EFI_INVALID_PARAMETER The Image was NULL or the ImageId was= 0. > > @retval EFI_OUT_OF_RESOURCES The bitmap could not be retrieved bec= ause there > > was not enough memory. > > > > **/ > > typedef > > -- > > 1.9.5.msysgit.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel