From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79DA78039D for ; Tue, 14 Mar 2017 18:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489541847; x=1521077847; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Je9qsp6ixMKlH7yXyaiVYTvCwmVWxpWu/rSs20+o8bE=; b=f/naoSsf1bBUUaxDdgYaoFkpXxMvOxql4g5FDP5hA5DcTXGa2cqr+oyM 6bO4SD7x5cb6ba51OfvRSGFiljSW6A==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2017 18:37:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,166,1486454400"; d="scan'208";a="67469313" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2017 18:37:26 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Mar 2017 18:37:26 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Mar 2017 18:37:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 15 Mar 2017 09:37:24 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Update some tool with shell=True Thread-Index: AQHSnSq7sSa4+mtdKUiiMvI67BTGGaGVHv9w Date: Wed, 15 Mar 2017 01:37:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6EFED5@shsmsx102.ccr.corp.intel.com> References: <1489540993-17788-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1489540993-17788-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Update some tool with shell=True X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 01:37:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Wednesday, March 15, 2017 9:23 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Update some tool with shell=3DTrue > >Pkcs7Sign, Rsa2048Sha256Sign and Rsa2048Sha256GenerateKeys doesn't work >on Linux. It needs to be changed with shell=3DTrue. > >Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3D423 >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py | 4= ++-- > .../Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKeys.py | 4 >++-- > BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 4 >++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py >b/BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py >index f0b2d8a..6412587 100644 >--- a/BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py >+++ b/BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py >@@ -4,11 +4,11 @@ > # This tool only support CertType - EFI_CERT_TYPE_PKCS7_GUID > # {0x4aafd29d, 0x68df, 0x49ee, {0x8a, 0xa9, 0x34, 0x7d, 0x37, 0x56, 0x6= 5, >0xa7}} > # > # This tool has been tested with OpenSSL. > # >-# Copyright (c) 2016, Intel Corporation. All rights reserved.
>+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the B= SD >License > # which accompanies this distribution. The full text of the license may = be >found at > # http://opensource.org/licenses/bsd-license.php > # >@@ -107,11 +107,11 @@ if __name__ =3D=3D '__main__': > > # > # Verify that Open SSL command is available > # > try: >- Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE) >+ Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE, shell=3DTrue) > except: > print 'ERROR: Open SSL command not available. Please verify PATH or = set >OPENSSL_PATH' > sys.exit(1) > > Version =3D Process.communicate() >diff --git >a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKey >s.py >b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKey >s.py >index 0b1624a..2dd6c20 100644 >--- >a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKey >s.py >+++ >b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKey >s.py >@@ -7,11 +7,11 @@ > # public keys to a file in a C structure format, and in verbose mode disp= lay > # one or more SHA 256 hashes of 2048 bit public keys in a C structure for= mat > # on STDOUT. > # This tool has been tested with OpenSSL 1.0.1e 11 Feb 2013 > # >-# Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.
>+# Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the B= SD >License > # which accompanies this distribution. The full text of the license may = be >found at > # http://opensource.org/licenses/bsd-license.php > # >@@ -69,11 +69,11 @@ if __name__ =3D=3D '__main__': > > # > # Verify that Open SSL command is available > # > try: >- Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE) >+ Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE, shell=3DTrue) > except: > print 'ERROR: Open SSL command not available. Please verify PATH or = set >OPENSSL_PATH' > sys.exit(1) > > Version =3D Process.communicate() >diff --git >a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py >b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py >index 199ebec..952583c 100644 >--- a/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py >+++ b/BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py >@@ -2,11 +2,11 @@ > # This tool encodes and decodes GUIDed FFS sections or FMP capsule for a >GUID type of > # EFI_CERT_TYPE_RSA2048_SHA256_GUID defined in the UEFI 2.4 >Specification as > # {0xa7717414, 0xc616, 0x4977, {0x94, 0x20, 0x84, 0x47, 0x12, 0xa7, 0x3= 5, >0xbf}} > # This tool has been tested with OpenSSL 1.0.1e 11 Feb 2013 > # >-# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
>+# Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the B= SD >License > # which accompanies this distribution. The full text of the license may = be >found at > # http://opensource.org/licenses/bsd-license.php > # >@@ -90,11 +90,11 @@ if __name__ =3D=3D '__main__': > > # > # Verify that Open SSL command is available > # > try: >- Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE) >+ Process =3D subprocess.Popen('%s version' % (OpenSslCommand), >stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.PIPE, shell=3DTrue) > except: > print 'ERROR: Open SSL command not available. Please verify PATH or = set >OPENSSL_PATH' > sys.exit(1) > > Version =3D Process.communicate() >-- >2.6.1.windows.1