public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: update error message for SKUID_IDENTIFIER format
Date: Thu, 6 Apr 2017 00:51:43 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D718CA8@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1491026351-54260-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Saturday, April 1, 2017 1:59 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: update error message for SKUID_IDENTIFIER format
> 
> Per DSC spec, the SkuUiName use '|' as separator, so this patch update
> the error message to use '|' but not space as separator.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  BaseTools/Source/Python/Common/Misc.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py
> index 1a5968a..390ef36 100644
> --- a/BaseTools/Source/Python/Common/Misc.py
> +++ b/BaseTools/Source/Python/Common/Misc.py
> @@ -2004,21 +2004,21 @@ class SkuClass():
>              try:
>                  self.SkuIdNumberSet = [SkuIds[k].strip() + 'U' for k in self.SkuIdSet]
>              except Exception:
>                  EdkLogger.error("build", PARAMETER_INVALID,
>                              ExtraData = "SKU-ID [%s] is not supported by the platform. [Valid SKU-ID: %s]"
> -                                      % (k, " ".join(SkuIds.keys())))
> +                                      % (k, " | ".join(SkuIds.keys())))
>          if len(self.SkuIdSet) == 2 and 'DEFAULT' in self.SkuIdSet and SkuIdentifier != 'ALL':
>              self.SkuIdSet.remove('DEFAULT')
>              self.SkuIdNumberSet.remove('0U')
>          for each in self.SkuIdSet:
>              if each in SkuIds:
>                  self.AvailableSkuIds[each] = SkuIds[each]
>              else:
>                  EdkLogger.error("build", PARAMETER_INVALID,
>                              ExtraData="SKU-ID [%s] is not supported by the platform. [Valid SKU-ID: %s]"
> -                                      % (each, " ".join(SkuIds.keys())))
> +                                      % (each, " | ".join(SkuIds.keys())))
> 
>      def __SkuUsageType(self):
> 
>          if len(self.SkuIdSet) == 1:
>              if self.SkuIdSet[0] == 'DEFAULT':
> --
> 2.6.1.windows.1



      reply	other threads:[~2017-04-06  0:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  5:59 [Patch] BaseTools: update error message for SKUID_IDENTIFIER format Yonghong Zhu
2017-04-06  0:51 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D718CA8@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox