From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option
Date: Thu, 6 Apr 2017 08:39:50 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D71A187@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8770F8@shsmsx102.ccr.corp.intel.com>
Good suggestion. I will update commit log.
>-----Original Message-----
>From: Zeng, Star
>Sent: Thursday, April 06, 2017 4:22 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove
>GCC -fno-builtin option
>
>How about to indicate the SHA-1:
>90defe7198a42b3157ae5d9b93714f891cf06e57 in the commit log like below?
>
>GCC -fno-builtin option is added into tools_def.template at
>90defe7198a42b3157ae5d9b93714f891cf06e57.
>So, there is no need to set it in module INF file.
>
>Thanks,
>Star
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Liming Gao
>Sent: Thursday, April 6, 2017 4:15 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -
>fno-builtin option
>
>GCC -fno-builtin option is added into tools_def.template. So, there is no need
>to set it in module INF file.
>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>---
> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>| 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git
>a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>index cfe42a6..d4d9a83 100644
>---
>a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>+++
>b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i
>+++ nf
>@@ -81,7 +81,6 @@
> MSFT:DEBUG_*_IPF_CC_FLAGS == /nologo /c /WX /GS- /W4 /EHs-c- /GR-
>/Gy /Os /FIAutoGen.h /QIPF_fr32 /Zi /X
> MSFT:RELEASE_*_IPF_CC_FLAGS == /nologo /c /WX /GS- /W4 /EHs-c- /GR-
>/Gy /Os /FIAutoGen.h /QIPF_fr32 /X
> INTEL:*_*_*_CC_FLAGS = /Oi-
>- GCC:*_*_*_CC_FLAGS = -fno-builtin
>
> # Oniguruma: potentially uninitialized local variable used
> MSFT:*_*_*_CC_FLAGS = /wd4701
>--
>2.8.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-04-06 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 8:15 [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option Liming Gao
2017-04-06 8:21 ` Zeng, Star
2017-04-06 8:39 ` Gao, Liming [this message]
2017-04-06 8:41 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D71A187@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox