public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Derek Lin <derek.lin2@hpe.com>
Subject: Re: [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall target.
Date: Wed, 12 Apr 2017 06:35:54 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D71D3A9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1491893068-8560-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Tuesday, April 11, 2017 2:44 PM
>To: edk2-devel@lists.01.org
>Cc: Derek Lin <derek.lin2@hpe.com>
>Subject: [edk2] [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall
>target.
>
>From: Derek Lin <derek.lin2@hpe.com>
>
>Remove module AutoGenTimeStamp file during clean or cleanall.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Derek Lin <derek.lin2@hpe.com>
>Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
>b/BaseTools/Source/Python/AutoGen/GenMake.py
>index ea07b97786..ac24bd8bbe 100644
>--- a/BaseTools/Source/Python/AutoGen/GenMake.py
>+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
>@@ -386,7 +386,7 @@ ${END}
> #
> clean:
> \t${BEGIN}${clean_command}
>-\t${END}
>+\t${END}\t$(RM) AutoGenTimeStamp
>
> #
> # clean all generated files
>@@ -395,6 +395,7 @@ cleanall:
> ${BEGIN}\t${cleanall_command}
> ${END}\t$(RM) *.pdb *.idb > NUL 2>&1
> \t$(RM) $(BIN_DIR)${separator}$(MODULE_NAME).efi
>+\t$(RM) AutoGenTimeStamp
>
> #
> # clean all dependent libraries built
>--
>2.11.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2017-04-12  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  6:44 [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall target Yonghong Zhu
2017-04-11  6:44 ` [PATCH 2/2] BaseTools: Fix re-build issue after tools_def/build_rule updated Yonghong Zhu
2017-04-12  6:35   ` Gao, Liming
2017-04-12  6:35 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D71D3A9@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox