public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Derek Lin <derek.lin2@hpe.com>
Subject: Re: [PATCH 2/2] BaseTools: Fix re-build issue after tools_def/build_rule updated.
Date: Wed, 12 Apr 2017 06:35:58 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D71D3B5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1491893068-8560-2-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Tuesday, April 11, 2017 2:44 PM
>To: edk2-devel@lists.01.org
>Cc: Derek Lin <derek.lin2@hpe.com>
>Subject: [edk2] [PATCH 2/2] BaseTools: Fix re-build issue after
>tools_def/build_rule updated.
>
>From: Derek Lin <derek.lin2@hpe.com>
>
>Add tools_def.txt and build_rule.txt to workspace autogen timestamp file.
>Now it will not skip autogen if this two file is updated.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Derek Lin <derek.lin2@hpe.com>
>Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
>b/BaseTools/Source/Python/AutoGen/AutoGen.py
>index 70c6c91186..3d3dfefdbc 100644
>--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
>@@ -64,6 +64,9 @@ gMakeTypeMap = {"MSFT":"nmake", "GCC":"gmake"}
> ## Build rule configuration file
> gDefaultBuildRuleFile = 'Conf/build_rule.txt'
>
>+## Tools definition configuration file
>+gDefaultToolsDefFile = 'Conf/tools_def.txt'
>+
> ## Build rule default version
> AutoGenReqBuildRuleVerNum = "0.1"
>
>@@ -721,6 +724,11 @@ class WorkspaceAutoGen(AutoGen):
>         AllWorkSpaceMetaFiles.add(self.MetaFile.Path)
>
>         #
>+        # add build_rule.txt & tools_def.txt
>+        #
>+        AllWorkSpaceMetaFiles.add(gDefaultBuildRuleFile)
>+        AllWorkSpaceMetaFiles.add(gDefaultToolsDefFile)
>+
>         # add BuildOption metafile
>         #
>         AllWorkSpaceMetaFiles.add(os.path.join(self.BuildDir, 'BuildOptions'))
>--
>2.11.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-04-12  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  6:44 [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall target Yonghong Zhu
2017-04-11  6:44 ` [PATCH 2/2] BaseTools: Fix re-build issue after tools_def/build_rule updated Yonghong Zhu
2017-04-12  6:35   ` Gao, Liming [this message]
2017-04-12  6:35 ` [PATCH 1/2] BaseTools: Fix build fail after clean or cleanall target Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D71D3B5@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox