public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Update the Conf directory to use the absolute path
Date: Mon, 17 Apr 2017 09:57:14 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D71EF91@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1492421009-25636-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Monday, April 17, 2017 5:23 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Update the Conf directory to use the absolute
>path
>
>Update the Conf directory to use the absolute path for build_rule.txt
>and tools_def.txt.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
>b/BaseTools/Source/Python/AutoGen/AutoGen.py
>index 3d3dfef..e1bdef0 100644
>--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
>@@ -60,14 +60,14 @@ gEfiVarStoreGuidPattern =
>re.compile("\s*guid\s*=\s*({.*?{.*?}\s*})")
> ## Mapping Makefile type
> gMakeTypeMap = {"MSFT":"nmake", "GCC":"gmake"}
>
>
> ## Build rule configuration file
>-gDefaultBuildRuleFile = 'Conf/build_rule.txt'
>+gDefaultBuildRuleFile = 'build_rule.txt'
>
> ## Tools definition configuration file
>-gDefaultToolsDefFile = 'Conf/tools_def.txt'
>+gDefaultToolsDefFile = 'tools_def.txt'
>
> ## Build rule default version
> AutoGenReqBuildRuleVerNum = "0.1"
>
> ## default file name for AutoGen
>@@ -724,12 +724,12 @@ class WorkspaceAutoGen(AutoGen):
>         AllWorkSpaceMetaFiles.add(self.MetaFile.Path)
>
>         #
>         # add build_rule.txt & tools_def.txt
>         #
>-        AllWorkSpaceMetaFiles.add(gDefaultBuildRuleFile)
>-        AllWorkSpaceMetaFiles.add(gDefaultToolsDefFile)
>+        AllWorkSpaceMetaFiles.add(os.path.join(GlobalData.gConfDirectory,
>gDefaultBuildRuleFile))
>+        AllWorkSpaceMetaFiles.add(os.path.join(GlobalData.gConfDirectory,
>gDefaultToolsDefFile))
>
>         # add BuildOption metafile
>         #
>         AllWorkSpaceMetaFiles.add(os.path.join(self.BuildDir, 'BuildOptions'))
>
>--
>2.6.1.windows.1



      reply	other threads:[~2017-04-17  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17  9:23 [Patch] BaseTools: Update the Conf directory to use the absolute path Yonghong Zhu
2017-04-17  9:57 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D71EF91@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox