From: "Gao, Liming" <liming.gao@intel.com>
To: "Fan, Jeff" <jeff.fan@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
Date: Tue, 25 Apr 2017 01:55:18 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D723806@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170424022928.8160-2-jeff.fan@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Fan, Jeff
>Sent: Monday, April 24, 2017 10:29 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Tian, Feng <feng.tian@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
>
>*Serach* should be *Search*
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Feng Tian <feng.tian@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Jeff Fan <jeff.fan@intel.com>
>---
> MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 2 +-
> MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c | 2
>+-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
>nt.c | 2 +-
> UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2
>+-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>index 647503b..f211cf5 100644
>--- a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>+++ b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>@@ -115,7 +115,7 @@ PeCoffGetSizeOfHeaders (
> **/
> UINTN
> EFIAPI
>-PeCoffSerachImageBase (
>+PeCoffSearchImageBase (
> IN UINTN Address
> );
>
>diff --git
>a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>index 00f6d7d..e1ddc8b 100644
>--- a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>+++ b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>@@ -332,7 +332,7 @@ PeCoffGetSizeOfHeaders (
> **/
> UINTN
> EFIAPI
>-PeCoffSerachImageBase (
>+PeCoffSearchImageBase (
> IN UINTN Address
> )
> {
>diff --git
>a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>index 6f3c419..f156fe2 100644
>---
>a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>+++
>b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>@@ -206,7 +206,7 @@ FindAndReportModuleImageInfo (
> //
> // Find Image Base
> //
>- Pe32Data = PeCoffSerachImageBase ((UINTN) mErrorMsgVersionAlert);
>+ Pe32Data = PeCoffSearchImageBase ((UINTN) mErrorMsgVersionAlert);
> if (Pe32Data != 0) {
> ImageContext.ImageAddress = Pe32Data;
> ImageContext.PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN)
>ImageContext.ImageAddress);
>diff --git
>a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>index 78ee182..dbfaae1 100644
>--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>@@ -120,7 +120,7 @@ DumpModuleImageInfo (
> VOID *PdbPointer;
> VOID *EntryPoint;
>
>- Pe32Data = PeCoffSerachImageBase (CurrentEip);
>+ Pe32Data = PeCoffSearchImageBase (CurrentEip);
> if (Pe32Data == 0) {
> InternalPrintMessage ("!!!! Can't find image information. !!!!\n");
> } else {
>diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>index 2cb0bbc..2d6b572 100755
>--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>@@ -178,7 +178,7 @@ DumpModuleInfoByIp (
> //
> // Find Image Base
> //
>- Pe32Data = PeCoffSerachImageBase (CallerIpAddress);
>+ Pe32Data = PeCoffSearchImageBase (CallerIpAddress);
> if (Pe32Data != 0) {
> DEBUG ((DEBUG_ERROR, "It is invoked from the instruction before
>IP(0x%p)", (VOID *) CallerIpAddress));
> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID *) Pe32Data);
>--
>2.9.3.windows.2
prev parent reply other threads:[~2017-04-25 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 2:29 [PATCH] PeCoffGetEntryPointLib: Fix spelling issue Jeff Fan
2017-04-24 2:29 ` Jeff Fan
2017-04-25 1:55 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D723806@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox