public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Nikolai SAOUKH <nms@otdel-1.org>
Subject: Re: [Patch] BaseTools: fix the typo in function name LanuchPostbuild
Date: Wed, 26 Apr 2017 09:13:54 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D725527@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1493197030-18012-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Wednesday, April 26, 2017 4:57 PM
>To: edk2-devel@lists.01.org
>Cc: Nikolai SAOUKH <nms@otdel-1.org>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: fix the typo in function name LanuchPostbuild
>
>From: Nikolai SAOUKH <nms@otdel-1.org>
>
>The patch fix function name typo LanuchPostbuild ==> LaunchPostbuild.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Nikolai SAOUKH <nms@otdel-1.org>
>---
> BaseTools/Source/Python/build/build.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 35e7037..45ccac1 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -987,11 +987,10 @@ class Build():
>                 PostbuildList[0] = mws.join(self.WorkspaceDir, PostbuildList[0])
>             if os.path.isfile(PostbuildList[0]):
>                 self.PostbuildScript = PostbuildList[0]
>                 self.Postbuild = ' '.join(PostbuildList)
>                 self.Postbuild += self.PassCommandOption(self.BuildTargetList,
>self.ArchList, self.ToolChainList)
>-                #self.LanuchPostbuild()
>             else:
>                 EdkLogger.error("Postbuild", POSTBUILD_ERROR, "the postbuild
>script %s is not exist.\n If you'd like to disable the Postbuild process, please
>use the format: -D POSTBUILD=\"\" " %(PostbuildList[0]))
>
>     def PassCommandOption(self, BuildTarget, TargetArch, ToolChain):
>         BuildStr = ''
>@@ -1074,11 +1073,11 @@ class Build():
>                 envs = itertools.ifilter(lambda l: len(l) == 2, envs)
>                 envs = itertools.imap(lambda l: [i.strip() for i in l], envs)
>                 os.environ.update(dict(envs))
>             EdkLogger.info("\n- Prebuild Done -\n")
>
>-    def LanuchPostbuild(self):
>+    def LaunchPostbuild(self):
>         if self.Postbuild:
>             EdkLogger.info("\n- Postbuild Start -\n")
>             if sys.platform == "win32":
>                 Process = Popen(self.Postbuild, stdout=PIPE, stderr=PIPE)
>             else:
>@@ -2329,11 +2328,11 @@ def Main():
>         Utils.Progressor.Abort()
>         Utils.ClearDuplicatedInf()
>
>     if ReturnCode == 0:
>         try:
>-            MyBuild.LanuchPostbuild()
>+            MyBuild.LaunchPostbuild()
>             Conclusion = "Done"
>         except:
>             Conclusion = "Failed"
>     elif ReturnCode == ABORT_ERROR:
>         Conclusion = "Aborted"
>--
>2.6.1.windows.1



      reply	other threads:[~2017-04-26  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  8:57 [Patch] BaseTools: fix the typo in function name LanuchPostbuild Yonghong Zhu
2017-04-26  9:13 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D725527@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox