From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8AA1321A134AE for ; Fri, 5 May 2017 02:13:43 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2017 02:13:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,291,1491289200"; d="scan'208";a="82899016" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 05 May 2017 02:13:43 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 May 2017 02:13:43 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 5 May 2017 02:13:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 5 May 2017 17:13:39 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: remove the hardcoded /bin/bash for PreBuild/PostBuild Thread-Index: AQHSw+6oGNIp8PqOb0G/OHC+4dJmc6Hld9YA Date: Fri, 5 May 2017 09:13:38 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D72A9B5@shsmsx102.ccr.corp.intel.com> References: <1493803272-57700-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1493803272-57700-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: remove the hardcoded /bin/bash for PreBuild/PostBuild X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 09:13:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, May 03, 2017 5:21 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: remove the hardcoded /bin/bash for >PreBuild/PostBuild > >This patch remove the hardcoded /bin/bash for PreBuild/PostBuild >scripts. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 45ccac1..bd14e27 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1037,11 +1037,11 @@ class Build(): > if sys.platform =3D=3D "win32": > args =3D ' && '.join((self.Prebuild, 'set > ' + PrebuildE= nvFile)) > Process =3D Popen(args, stdout=3DPIPE, stderr=3DPIPE) > else: > args =3D ' && '.join((self.Prebuild, 'env > ' + PrebuildE= nvFile)) >- Process =3D Popen(args, stdout=3DPIPE, stderr=3DPIPE, she= ll=3DTrue, >executable=3D"/bin/bash") >+ Process =3D Popen(args, stdout=3DPIPE, stderr=3DPIPE, she= ll=3DTrue) > > # launch two threads to read the STDOUT and STDERR > EndOfProcedure =3D Event() > EndOfProcedure.clear() > if Process.stdout: >@@ -1079,11 +1079,11 @@ class Build(): > if self.Postbuild: > EdkLogger.info("\n- Postbuild Start -\n") > if sys.platform =3D=3D "win32": > Process =3D Popen(self.Postbuild, stdout=3DPIPE, stderr= =3DPIPE) > else: >- Process =3D Popen(self.Postbuild, stdout=3DPIPE, stderr= =3DPIPE, shell=3DTrue, >executable=3D"/bin/bash") >+ Process =3D Popen(self.Postbuild, stdout=3DPIPE, stderr= =3DPIPE, >shell=3DTrue) > # launch two threads to read the STDOUT and STDERR > EndOfProcedure =3D Event() > EndOfProcedure.clear() > if Process.stdout: > StdOutThread =3D Thread(target=3DReadMessage, args=3D(Pro= cess.stdout, >EdkLogger.info, EndOfProcedure)) >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel