From: "Gao, Liming" <liming.gao@intel.com>
To: Sergey Temerkhanov <s.temerkhanov@gmail.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg: Fix undefined behavior on variadic parameters
Date: Tue, 16 May 2017 05:10:35 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D72E8BC@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1494903391-716-2-git-send-email-s.temerkhanov@gmail.com>
Sergey:
Could you give more detail on the undefined behavior on variadic parameters?
I see https://bugzilla.tianocore.org/show_bug.cgi?id=410 describe this issues found in the latest CLANG tool chain. Do you find other tool chain reports it?
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sergey Temerkhanov
> Sent: Tuesday, May 16, 2017 10:57 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters
>
> Fix undefined behavior by avoiding parameter type promotion
>
> Signed-off-by: Sergey Temerkhanov <s.temerkhanov@gmail.com>
> ---
> MdePkg/Include/Library/UefiLib.h | 2 +-
> MdePkg/Library/UefiLib/UefiLib.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 0b14792..4e4697c 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -818,7 +818,7 @@ CHAR8 *
> EFIAPI
> GetBestLanguage (
> IN CONST CHAR8 *SupportedLanguages,
> - IN BOOLEAN Iso639Language,
> + IN UINTN Iso639Language,
> ...
> );
>
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index a7eee01..74528ec 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -1514,7 +1514,7 @@ CHAR8 *
> EFIAPI
> GetBestLanguage (
> IN CONST CHAR8 *SupportedLanguages,
> - IN BOOLEAN Iso639Language,
> + IN UINTN Iso639Language,
> ...
> )
> {
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-05-16 5:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 2:56 [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31 Sergey Temerkhanov
2017-05-16 2:56 ` [PATCH] MdePkg: Fix undefined behavior on variadic parameters Sergey Temerkhanov
2017-05-16 5:10 ` Gao, Liming [this message]
2017-05-16 12:10 ` Sergei Temerkhanov
2017-05-17 15:30 ` Gao, Liming
2017-05-18 0:26 ` Sergei Temerkhanov
2017-05-18 3:06 ` Andrew Fish
2017-05-19 3:01 ` Sergei Temerkhanov
2017-05-18 10:19 ` Laszlo Ersek
2017-05-19 1:35 ` Gao, Liming
2017-05-19 8:12 ` Laszlo Ersek
2017-05-19 2:45 ` Sergei Temerkhanov
2017-05-19 8:16 ` Laszlo Ersek
2017-05-24 2:14 ` Gao, Liming
2017-05-24 2:46 ` Kinney, Michael D
2017-05-24 11:15 ` Sergei Temerkhanov
2017-05-16 2:56 ` [PATCH] MdeModulePkg: " Sergey Temerkhanov
2017-05-18 16:08 ` [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31 Ard Biesheuvel
2017-05-19 2:37 ` Sergei Temerkhanov
2017-05-19 10:26 ` Leif Lindholm
2017-05-19 14:31 ` Sergei Temerkhanov
2017-05-22 17:45 ` Leif Lindholm
2017-05-23 10:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D72E8BC@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox