From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D351F2095A1D5 for ; Thu, 18 May 2017 18:30:00 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 18 May 2017 18:30:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,361,1491289200"; d="scan'208";a="89321348" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 18 May 2017 18:30:00 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 18 May 2017 18:29:59 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.117]) with mapi id 14.03.0319.002; Fri, 19 May 2017 09:29:57 +0800 From: "Gao, Liming" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" , Andrew Fish Thread-Topic: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present Thread-Index: AQHSz/zGDaOywvETyU+FiPfsAI6d0qH63kEw Date: Fri, 19 May 2017 01:29:57 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D730AAD@shsmsx102.ccr.corp.intel.com> References: <1495128744-24324-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1495128744-24324-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 01:30:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: The code change is good. Reviewed-by: Liming Gao But, I think we still need to figure out the solution to create resource= section in XCODE5. =20 Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Michael Kinney >Sent: Friday, May 19, 2017 1:32 AM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Zeng, Star ; >Andrew Fish >Subject: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package >not present > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D554 > >Update LogoDxe module to exit with an error instead of >ASSERT_EFI_ERROR() if the HII Package with the logo image >is not present. > >If a tool chain does not support generation of PE/COFF >resource sections, then this module can not produce the logo >from an HII Image Package. XCODE5 is an example of a tool >chain that does not currently support generation of PE/COFF >resource sections. > >Cc: Star Zeng >Cc: Eric Dong >Cc: Andrew Fish >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Michael Kinney >--- > MdeModulePkg/Logo/Logo.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c >index 313dd4a..b34724a 100644 >--- a/MdeModulePkg/Logo/Logo.c >+++ b/MdeModulePkg/Logo/Logo.c >@@ -1,7 +1,7 @@ > /** @file > Logo DXE Driver, install Edkii Platform Logo protocol. > >-Copyright (c) 2016, Intel Corporation. All rights reserved.
>+Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD >License > which accompanies this distribution. The full text of the license may be= found >at >@@ -133,7 +133,9 @@ InitializeLogo ( > NULL, > EFI_OPEN_PROTOCOL_GET_PROTOCOL > ); >- ASSERT_EFI_ERROR (Status); >+ if (EFI_ERROR (Status)) { >+ return Status; >+ } > > // > // Publish HII package list to HII Database. >-- >2.6.3.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel