From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly
Date: Fri, 19 May 2017 02:05:41 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D730B11@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1495096876-48412-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Thursday, May 18, 2017 4:41 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH] MdeModulePkg PCD: Fix
>TmpTokenSpaceBufferCount not assigned correctly
>
>When DynamicEx PCD is only used in PEI code, but not DXE code,
>current implementation of DxePcdGetNextTokenSpace does not assign
>TmpTokenSpaceBufferCount correctly, but leaves it as initial value,
>then DxePcdGetNextTokenSpace may return incorrect token space guid
>and status.
>
>This patch is to fix this issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c
>b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c
>index 9d710bbf1fb7..326644c53105 100644
>--- a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c
>+++ b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c
>@@ -1296,6 +1296,7 @@ DxePcdGetNextTokenSpace (
> (EFI_GUID *)((UINT8 *)mPcdDatabase.PeiDb +
>mPcdDatabase.PeiDb->GuidTableOffset)
> );
> CopyMem (TmpTokenSpaceBuffer, PeiTokenSpaceTable, sizeof
>(EFI_GUID*) * PeiTokenSpaceTableSize);
>+ TmpTokenSpaceBufferCount = PeiTokenSpaceTableSize;
> FreePool (PeiTokenSpaceTable);
> }
>
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-05-19 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 8:41 [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly Star Zeng
2017-05-19 2:05 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D730B11@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox