From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 254412095A1E3 for ; Thu, 18 May 2017 19:05:48 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2017 19:05:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,361,1491289200"; d="scan'208";a="263825816" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 18 May 2017 19:05:46 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 18 May 2017 19:05:46 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 18 May 2017 19:05:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 19 May 2017 10:05:42 +0800 From: "Gao, Liming" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly Thread-Index: AQHSz7KN8MLwoDF+ZkWayqcDac+L4aH66W0g Date: Fri, 19 May 2017 02:05:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D730B11@shsmsx102.ccr.corp.intel.com> References: <1495096876-48412-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1495096876-48412-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg PCD: Fix TmpTokenSpaceBufferCount not assigned correctly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 02:05:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sta= r >Zeng >Sent: Thursday, May 18, 2017 4:41 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Zeng, Star >Subject: [edk2] [PATCH] MdeModulePkg PCD: Fix >TmpTokenSpaceBufferCount not assigned correctly > >When DynamicEx PCD is only used in PEI code, but not DXE code, >current implementation of DxePcdGetNextTokenSpace does not assign >TmpTokenSpaceBufferCount correctly, but leaves it as initial value, >then DxePcdGetNextTokenSpace may return incorrect token space guid >and status. > >This patch is to fix this issue. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Star Zeng >--- > MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c >b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c >index 9d710bbf1fb7..326644c53105 100644 >--- a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c >+++ b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c >@@ -1296,6 +1296,7 @@ DxePcdGetNextTokenSpace ( > (EFI_GUID *)((UINT8 *)mPcdDatabase.PeiDb + >mPcdDatabase.PeiDb->GuidTableOffset) > ); > CopyMem (TmpTokenSpaceBuffer, PeiTokenSpaceTable, sizeof >(EFI_GUID*) * PeiTokenSpaceTableSize); >+ TmpTokenSpaceBufferCount =3D PeiTokenSpaceTableSize; > FreePool (PeiTokenSpaceTable); > } > >-- >2.7.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel