public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Andrew Fish <afish@apple.com>
Subject: Re: [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs
Date: Mon, 22 May 2017 04:13:06 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D73270A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1495176736-28376-1-git-send-email-michael.d.kinney@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Kinney, Michael D
>Sent: Friday, May 19, 2017 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Andrew Fish <afish@apple.com>; Gao, Liming <liming.gao@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs
>
>* Add -D NO_MSABI_VAARGS to X64 XCODE CC_FLAGS
>* Clean up XCODE5 tool chain statements
>
>Cc: Andrew Fish <afish@apple.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
>Michael Kinney (2):
>  BaseTools: Add -D NO_MSABI_VARGS to X64 XCODE5 CC_FLAGS
>  BaseTools: Clean up tools_def.template for XCODE5
>
> BaseTools/Conf/tools_def.template | 60 ++++++++++++++++++++------------
>-------
> 1 file changed, 31 insertions(+), 29 deletions(-)
>
>--
>2.6.3.windows.1



      parent reply	other threads:[~2017-05-22  4:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  6:52 [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs Michael Kinney
2017-05-19  6:52 ` [Patch 1/2] BaseTools: Add -D NO_MSABI_VARGS to X64 XCODE5 CC_FLAGS Michael Kinney
2017-05-19 12:49   ` Ard Biesheuvel
2017-05-19 16:46     ` Andrew Fish
2017-05-19 16:56       ` Ard Biesheuvel
2017-05-19  6:52 ` [Patch 2/2] BaseTools: Clean up tools_def.template for XCODE5 Michael Kinney
2017-05-19 21:36 ` [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs Andrew Fish
2017-05-22  4:13 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D73270A@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox