From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BF7B219FFEE1 for ; Tue, 23 May 2017 19:14:09 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 23 May 2017 19:14:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,384,1491289200"; d="scan'208";a="104649603" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 23 May 2017 19:14:09 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 May 2017 19:14:08 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 May 2017 19:14:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Wed, 24 May 2017 10:14:06 +0800 From: "Gao, Liming" To: 'Laszlo Ersek' , Sergei Temerkhanov CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters Thread-Index: AQHSzfAyZrqQmCd2hkaaBmjkinJcnqH2aIWQ///wYICAAwWeAIABE3aAgABcaICABufIkA== Date: Wed, 24 May 2017 02:14:05 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D733532@shsmsx102.ccr.corp.intel.com> References: <1494903391-716-1-git-send-email-s.temerkhanov@gmail.com> <1494903391-716-2-git-send-email-s.temerkhanov@gmail.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D72E8BC@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg: Fix undefined behavior on variadic parameters X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 02:14:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 U2VyZ2V5Og0KICBUaGlzIHBhdGNoIHVwZGF0ZXMgQVBJIGludGVyZmFjZS4gSSBzdGlsbCBuZWVk IHRvIHZlcmlmeSBpdHMgZnVuY3Rpb25hbGl0eSBvbiBvdGhlciB0b29sIGNoYWluLiBJIHdpbGwg Z2l2ZSB5b3UgZmVlZGJhY2sgYWZ0ZXIgSSBhbSBkb25lLiANCg0KVGhhbmtzDQpMaW1pbmcNCj4t LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZyb206IExhc3psbyBFcnNlayBbbWFpbHRvOmxl cnNla0ByZWRoYXQuY29tXQ0KPlNlbnQ6IEZyaWRheSwgTWF5IDE5LCAyMDE3IDQ6MTYgUE0NCj5U bzogU2VyZ2VpIFRlbWVya2hhbm92IDxzLnRlbWVya2hhbm92QGdtYWlsLmNvbT4NCj5DYzogR2Fv LCBMaW1pbmcgPGxpbWluZy5nYW9AaW50ZWwuY29tPjsgZWRrMi1kZXZlbEBsaXN0cy4wMS5vcmcN Cj5TdWJqZWN0OiBSZTogW2VkazJdIFtQQVRDSF0gTWRlUGtnOiBGaXggdW5kZWZpbmVkIGJlaGF2 aW9yIG9uIHZhcmlhZGljDQo+cGFyYW1ldGVycw0KPg0KPk9uIDA1LzE5LzE3IDA0OjQ1LCBTZXJn ZWkgVGVtZXJraGFub3Ygd3JvdGU6DQo+PiBPbiBUaHUsIE1heSAxOCwgMjAxNyBhdCAxOjE5IFBN LCBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPiB3cm90ZToNCj4+PiBPbiAwNS8xNi8x NyAxNDoxMCwgU2VyZ2VpIFRlbWVya2hhbm92IHdyb3RlOg0KPj4+PiBPbiBUdWUsIE1heSAxNiwg MjAxNyBhdCA4OjEwIEFNLCBHYW8sIExpbWluZyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+d3Jv dGU6DQo+Pj4+PiBTZXJnZXk6DQo+Pj4+PiAgIENvdWxkIHlvdSBnaXZlIG1vcmUgZGV0YWlsIG9u IHRoZSB1bmRlZmluZWQgYmVoYXZpb3Igb24gdmFyaWFkaWMNCj5wYXJhbWV0ZXJzPw0KPj4+Pj4N Cj4+Pj4+ICAgSSBzZWUgaHR0cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNn aT9pZD00MTAgZGVzY3JpYmUgdGhpcw0KPmlzc3VlcyBmb3VuZCBpbiB0aGUgbGF0ZXN0IENMQU5H IHRvb2wgY2hhaW4uIERvIHlvdSBmaW5kIG90aGVyIHRvb2wgY2hhaW4NCj5yZXBvcnRzIGl0Pw0K Pj4+Pg0KPj4+PiBZZXMsIHRoaXMgaXMgZXhhY3RseSB0aGUgYnVnIHRoaXMgcGF0Y2ggZml4ZXMu DQo+Pj4+DQo+Pj4+IEFzIHBlciB0aGUgQzk5IHN0YW5kYXJkOg0KPj4+PiAiVGhlIHBhcmFtZXRl ciBwYXJtTiBpcyB0aGUgaWRlbnRpZmllciBvZiB0aGUgcmlnaHRtb3N0IHBhcmFtZXRlciBpbg0K Pj4+PiB0aGUgdmFyaWFibGUgcGFyYW1ldGVyIGxpc3QgaW4gdGhlIGZ1bmN0aW9uIGRlZmluaXRp b24gKHRoZSBvbmUganVzdA0KPj4+PiBiZWZvcmUgdGhlICwgLi4uKS4gSWYgdGhlIHBhcmFtZXRl ciBwYXJtTiBpcyBkZWNsYXJlZCB3aXRoIHRoZQ0KPj4+PiByZWdpc3RlciBzdG9yYWdlIGNsYXNz LCB3aXRoIGEgZnVuY3Rpb24gb3IgYXJyYXkgdHlwZSwgb3Igd2l0aCBhIHR5cGUNCj4+Pj4gdGhh dCBpcyBub3QgY29tcGF0aWJsZSB3aXRoIHRoZSB0eXBlIHRoYXQgcmVzdWx0cyBhZnRlciBhcHBs aWNhdGlvbiBvZg0KPj4+PiB0aGUgZGVmYXVsdCBhcmd1bWVudCBwcm9tb3Rpb25zLCB0aGUgYmVo YXZpb3IgaXMgdW5kZWZpbmVkLiINCj4+Pj4NCj4+Pj4gVGhhdCdzIGV4YWN0bHkgdGhlIGNhc2Ug aGVyZSBzaW5jZSBCT09MRUFOIGlzIGEgdHlwZWRlZiBmb3IgdW5zaWduZWQNCj4+Pj4gY2hhci4g SXQgdW5kZXJnb2VzIGEgcHJvbW90aW9uIHRvIGFuIHVuc2lnbmVkIGludA0KPj4+DQo+Pj4gU2lk ZSB0b3BpYzoNCj4+Pg0KPj4+IEl0IGlzIHByb21vdGVkLCBidXQgbm90IHRvICJ1bnNpZ25lZCBp bnQiLg0KPj4+DQo+Pj4gVGhlIHN0YW5kYXJkIHNheXMsIGluICI2LjMuMS4xIEJvb2xlYW4sIGNo YXJhY3RlcnMsIGFuZCBpbnRlZ2VycyIsDQo+Pj4gcGFyYWdyYXBoIDIsDQo+Pj4NCj4+PiAgICAg VGhlIGZvbGxvd2luZyBtYXkgYmUgdXNlZCBpbiBhbiBleHByZXNzaW9uIHdoZXJldmVyIGFuIC9p bnQvIG9yDQo+Pj4gICAgIC91bnNpZ25lZCBpbnQvIG1heSBiZSB1c2VkOg0KPj4+DQo+Pj4gICAg IOKAlCBBbiBvYmplY3Qgb3IgZXhwcmVzc2lvbiB3aXRoIGFuIGludGVnZXIgdHlwZSB3aG9zZSBp bnRlZ2VyDQo+Pj4gICAgICAgY29udmVyc2lvbiByYW5rIGlzIGxlc3MgdGhhbiBvciBlcXVhbCB0 byB0aGUgcmFuayBvZiAvaW50LyBhbmQNCj4+PiAgICAgICAvdW5zaWduZWQgaW50Ly4NCj4+PiAg ICAg4oCUIEEgYml0LWZpZWxkIG9mIHR5cGUgL19Cb29sLywgL2ludC8sIC9zaWduZWQgaW50Lywg b3INCj4+PiAgICAgICAvdW5zaWduZWQgaW50Ly4NCj4+Pg0KPj4+ICAgICBJZiBhbiAvaW50LyBj YW4gcmVwcmVzZW50IGFsbCB2YWx1ZXMgb2YgdGhlIG9yaWdpbmFsIHR5cGUsIHRoZSB2YWx1ZQ0K Pj4+ICAgICBpcyBjb252ZXJ0ZWQgdG8gYW4gL2ludC87IG90aGVyd2lzZSwgaXQgaXMgY29udmVy dGVkIHRvIGFuDQo+Pj4gICAgIC91bnNpZ25lZCBpbnQvLiBUaGVzZSBhcmUgY2FsbGVkIHRoZSAv aW50ZWdlciBwcm9tb3Rpb25zLy4gWy4uLl0NCj4+Pg0KPj4+IE9uIGFsbCBzdXBwb3J0ZWQgZWRr MiBwbGF0Zm9ybXMsICJ1bnNpZ25lZCBjaGFyIidzIHJhbmdlIGlzIDAuLjI1NQ0KPj4+IGluY2x1 c2l2ZSwgd2hpY2ggY2FuIGJlIHJlcHJlc2VudGVkIGJ5ICJpbnQiIChhZ2FpbiBvbiBhbGwgc3Vw cG9ydGVkDQo+Pj4gZWRrMiBwbGF0Zm9ybXMpLiBTbyB0aGUgcHJvbW90aW9uIG9jY3VycyB0byAi aW50Iiwgbm90ICJ1bnNpZ25lZCBpbnQiDQo+Pj4NCj4+Pg0KPj4+IEZ1cnRoZXJtb3JlLCBpbiBw bGFjZSBvZiB0aGUgc3VnZ2VzdGVkIFVJTlROIHR5cGUgKHdoaWNoIGlzIGZpbmUpLCB0aGUNCj4+ PiBmb2xsb3dpbmcgZnVydGhlciB0eXBlcyB3b3VsZCBiZSBjb3JyZWN0OiBJTlQzMiwgVUlOVDMy LCBJTlQ2NCwgVUlOVDY0LA0KPj4+IElOVE4uDQo+Pg0KPj4gT24gMzItYml0IGFyY2hpdGVjdHVy ZXMsIHVzaW5nIDY0LWJpdCB0eXBlcyBoZXJlIG1heSBjaGFuZ2UgdGhlIEFCSS4gV2hpY2gNCj5t aWdodA0KPj4gYWZmZWN0IHNvbWUgY29ybmVyIGNhc2VzIGxpa2UgbGlua2luZyBwcmVjb21waWxl ZCBvYmplY3QgZmlsZXMgdG8gdGhlDQo+PiBsaWJyYXJ5IGluIHF1ZXN0aW9uLg0KPg0KPlRydWUu DQo+DQo+SSBtaXNzZWQgdGhlIGZhY3QgdGhhdCBpbiBlZGsyIHlvdSBjYW4gaGF2ZSBiaW5hcnkt b25seSBsaWJyYXJ5DQo+aW5zdGFuY2VzLiBJIHNob3VsZCBoYXZlIHJlbWVtYmVyZWQsIGFmdGVy IGFsbCBJIGhhZCBmaWxlZA0KPjxodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19i dWcuY2dpP2lkPTQ2Mz4gOikNCj4NCj5TbyB5ZXMsIFVJTlROIGlzIHRoZSBiZXN0IGNob2ljZTsg aXQga2VlcHMgYmluYXJ5IGNvbXBhdCBiZXlvbmQNCj5ldmVyeXRoaW5nIGVsc2UuDQo+DQo+VGhh bmtzIQ0KPkxhc3psbw0KPg0KPj4NCj4+PiBUaGUgcmVhc29uIGlzIHRoYXQgYWxsIG9mIHRoZXNl IG1hcCB0byBzdGFuZGFyZCBDIHR5cGVzLCBvbiBhbGwNCj4+PiBlZGsyIHBsYXRmb3Jtcywgd2hv c2UgaW50ZWdlciBjb252ZXJzaW9uIHJhbmtzIGFyZSBub3QgbGVzcyB0aGFuIHRoYXQgb2YNCj4+ PiAiaW50IiBhbmQgInVuc2lnbmVkIGludCIuIEhlbmNlIHRoZXkgYXJlIGFsbCB1bmFmZmVjdGVk IGJ5IHRoZSBpbnRlZ2VyDQo+Pj4gcHJvbW90aW9ucy4NCj4+Pg0KPj4+IChUaGlzIGRpZ3Jlc3Np b24gZG9lcyBub3QgYWZmZWN0IHlvdXIgbWFpbiBwb2ludCwgd2hpY2ggcmVtYWlucyBjb3JyZWN0 Ow0KPj4+IEkganVzdCB3YW50ZWQgdG8gYmUgcHJlY2lzZSBoZXJlLCBzaW5jZSB3ZSdyZSBxdW90 aW5nIHRoZSBzdGFuZGFyZC4pDQo+Pj4NCj4+PiBUaGFua3MNCj4+PiBMYXN6bG8NCj4+Pg0KPj4+ PiB3aGljaCBpcyBub3QgYQ0KPj4+PiBjb21wYXRpYmxlIHR5cGUgZm9yIHVuc2lnbmVkIGNoYXIu IENvcnJlY3QgbWUgaWYgSSdtIHdyb25nLg0KPj4+Pg0KPj4+PiBSZWdhcmRzLA0KPj4+PiBTZXJn ZXkNCj4+Pj4NCj4+Pj4+DQo+Pj4+PiBUaGFua3MNCj4+Pj4+IExpbWluZw0KPj4+Pj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+Pj4+Pj4gRnJvbTogZWRrMi1kZXZlbCBbbWFpbHRvOmVk azItZGV2ZWwtYm91bmNlc0BsaXN0cy4wMS5vcmddIE9uIEJlaGFsZg0KPk9mIFNlcmdleSBUZW1l cmtoYW5vdg0KPj4+Pj4+IFNlbnQ6IFR1ZXNkYXksIE1heSAxNiwgMjAxNyAxMDo1NyBBTQ0KPj4+ Pj4+IFRvOiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0KPj4+Pj4+IFN1YmplY3Q6IFtlZGsyXSBb UEFUQ0hdIE1kZVBrZzogRml4IHVuZGVmaW5lZCBiZWhhdmlvciBvbiB2YXJpYWRpYw0KPnBhcmFt ZXRlcnMNCj4+Pj4+Pg0KPj4+Pj4+IEZpeCB1bmRlZmluZWQgYmVoYXZpb3IgYnkgYXZvaWRpbmcg cGFyYW1ldGVyIHR5cGUgcHJvbW90aW9uDQo+Pj4+Pj4NCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBT ZXJnZXkgVGVtZXJraGFub3YgPHMudGVtZXJraGFub3ZAZ21haWwuY29tPg0KPj4+Pj4+IC0tLQ0K Pj4+Pj4+ICBNZGVQa2cvSW5jbHVkZS9MaWJyYXJ5L1VlZmlMaWIuaCB8IDIgKy0NCj4+Pj4+PiAg TWRlUGtnL0xpYnJhcnkvVWVmaUxpYi9VZWZpTGliLmMgfCAyICstDQo+Pj4+Pj4gIDIgZmlsZXMg Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+Pj4+DQo+Pj4+Pj4g ZGlmZiAtLWdpdCBhL01kZVBrZy9JbmNsdWRlL0xpYnJhcnkvVWVmaUxpYi5oDQo+Yi9NZGVQa2cv SW5jbHVkZS9MaWJyYXJ5L1VlZmlMaWIuaA0KPj4+Pj4+IGluZGV4IDBiMTQ3OTIuLjRlNDY5N2Mg MTAwNjQ0DQo+Pj4+Pj4gLS0tIGEvTWRlUGtnL0luY2x1ZGUvTGlicmFyeS9VZWZpTGliLmgNCj4+ Pj4+PiArKysgYi9NZGVQa2cvSW5jbHVkZS9MaWJyYXJ5L1VlZmlMaWIuaA0KPj4+Pj4+IEBAIC04 MTgsNyArODE4LDcgQEAgQ0hBUjggKg0KPj4+Pj4+ICBFRklBUEkNCj4+Pj4+PiAgR2V0QmVzdExh bmd1YWdlICgNCj4+Pj4+PiAgICBJTiBDT05TVCBDSEFSOCAgKlN1cHBvcnRlZExhbmd1YWdlcywN Cj4+Pj4+PiAtICBJTiBCT09MRUFOICAgICAgSXNvNjM5TGFuZ3VhZ2UsDQo+Pj4+Pj4gKyAgSU4g VUlOVE4gICAgICBJc282MzlMYW5ndWFnZSwNCj4+Pj4+PiAgICAuLi4NCj4+Pj4+PiAgICApOw0K Pj4+Pj4+DQo+Pj4+Pj4gZGlmZiAtLWdpdCBhL01kZVBrZy9MaWJyYXJ5L1VlZmlMaWIvVWVmaUxp Yi5jDQo+Yi9NZGVQa2cvTGlicmFyeS9VZWZpTGliL1VlZmlMaWIuYw0KPj4+Pj4+IGluZGV4IGE3 ZWVlMDEuLjc0NTI4ZWMgMTAwNjQ0DQo+Pj4+Pj4gLS0tIGEvTWRlUGtnL0xpYnJhcnkvVWVmaUxp Yi9VZWZpTGliLmMNCj4+Pj4+PiArKysgYi9NZGVQa2cvTGlicmFyeS9VZWZpTGliL1VlZmlMaWIu Yw0KPj4+Pj4+IEBAIC0xNTE0LDcgKzE1MTQsNyBAQCBDSEFSOCAqDQo+Pj4+Pj4gIEVGSUFQSQ0K Pj4+Pj4+ICBHZXRCZXN0TGFuZ3VhZ2UgKA0KPj4+Pj4+ICAgIElOIENPTlNUIENIQVI4ICAqU3Vw cG9ydGVkTGFuZ3VhZ2VzLA0KPj4+Pj4+IC0gIElOIEJPT0xFQU4gICAgICBJc282MzlMYW5ndWFn ZSwNCj4+Pj4+PiArICBJTiBVSU5UTiAgICAgIElzbzYzOUxhbmd1YWdlLA0KPj4+Pj4+ICAgIC4u Lg0KPj4+Pj4+ICAgICkNCj4+Pj4+PiAgew0KPj4+Pj4+IC0tDQo+Pj4+Pj4gMi43LjQNCj4+Pj4+ Pg0KPj4+Pj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f DQo+Pj4+Pj4gZWRrMi1kZXZlbCBtYWlsaW5nIGxpc3QNCj4+Pj4+PiBlZGsyLWRldmVsQGxpc3Rz LjAxLm9yZw0KPj4+Pj4+IGh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vZWRr Mi1kZXZlbA0KPj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXw0KPj4+PiBlZGsyLWRldmVsIG1haWxpbmcgbGlzdA0KPj4+PiBlZGsyLWRldmVsQGxpc3Rz LjAxLm9yZw0KPj4+PiBodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2VkazIt ZGV2ZWwNCj4+Pj4NCj4+Pg0KDQo=