public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"Shaw, Kevin W" <kevin.w.shaw@intel.com>
Subject: Re: [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
Date: Sat, 27 May 2017 05:31:45 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D73F1B1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1495852097-34208-2-git-send-email-michael.d.kinney@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, May 27, 2017 10:28 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
> Subject: [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
> 
> bugzilla.tianocore.org/show_bug.cgi?id=548
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md | 11 ++---------
>  README.md                                                |  3 ++-
>  2 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> index 6cf125a..0700700 100644
> --- a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> +++ b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> @@ -37,8 +37,7 @@ These are optional sections.
> 
>  Defines the EDK II `[LibraryClasses]` section content. The Library Class
>  entries are single lines with one or two fields, separated by the pipe "|"
> -character. The optional `MODULE_TYPE` refers to the supported Module Type, and
> -may be a comma separated list of supported module types.
> +character.
> 
>  The EDK II build system will provide an option to generate an "As Built" INF
>  that can be used to distribution binary modules. Since a binary distribution
> @@ -65,13 +64,7 @@ in the entries is prohibited.
>                           [<Statements>]
>  <com_attrs>          ::= {".common"} {<attrs>}
>  <attrs>              ::= <Archs> ["," <TS> "LibraryClasses" <attrs>]*
> -<Archs>              ::= "." <arch> [<MODULE_TYPE>]
> -<MODULE_TYPE>        ::= "." <ModuleType> [<FS> <ModuleType>]*
> -<ModuleType>         ::= {"BASE"} {"SEC"} {"PEI_CORE"} {"PEIM"}
> -                         {"DXE_CORE"} {"DXE_DRIVER"} {"SMM_CORE"}
> -                         {"DXE_SMM_DRIVER"} {"DXE_RUNTIME_DRIVER"}
> -                         {"DXE_SAL_DRIVER"} {"UEFI_DRIVER"}
> -                         {"UEFI_APPLICATION"} {"USER_DEFINED"}
> +<Archs>              ::= "." <arch>
>  <Statements>         ::= {<SourceContent>*} {<AsBuiltInfo>}
>  <SourceContent>      ::= <TS> {<SourceStmts>} {<MacroDefinition>}
>  <SourceStmts>        ::= [<RecInstanceCmt> <Filename> <EOL>] <TS> <Keyword>
> diff --git a/README.md b/README.md
> index 57e05d2..e256239 100644
> --- a/README.md
> +++ b/README.md
> @@ -192,4 +192,5 @@ Copyright (c) 2007-2017, Intel Corporation. All rights reserved.
>  |            | Updated other sections to specify how the build system will evaluate the Feature Flag Expression
> |               |
>  |            | Prohibit using #include statements in UNI files specified in the MODULE_UNI_FILE entry
> |               |
>  | 1.25       | Revised WORKSPACE wording for updated build system that can handle packages located outside of the WORKSPACE
> directory tree (refer to the TianoCore.org/EDKII website for additional instructions on setting up a development environment).
> | January 2016  |
> -| 1.26       | Convert to GitBooks
> | March 2017    |
> +| 1.26       | Convert to GitBooks
> | May 2017      |
> +|            | [#548](https://bugzilla.tianocore.org/show_bug.cgi?id=548) [INF spec] INF [LibraryClasses] section should not
> support ModuleType
> |               |
> --
> 2.6.3.windows.1



      reply	other threads:[~2017-05-27  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27  2:28 [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section Michael Kinney
2017-05-27  2:28 ` Michael Kinney
2017-05-27  5:31   ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D73F1B1@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox