public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
@ 2017-05-27  2:28 Michael Kinney
  2017-05-27  2:28 ` Michael Kinney
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kinney @ 2017-05-27  2:28 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

bugzilla.tianocore.org/show_bug.cgi?id=548

GitHub branch for review:

* https://github.com/mdkinney/edk2-InfSpecification/tree/Bugzilla_548_RemoveModuleTypeFromLibraryClasses

GitHub word diff view of the patches in this series:

* [1/1] https://github.com/mdkinney/edk2-InfSpecification/commit/a2e7fc99de0da9583f409ee1b3f3247bf2179ae3?w=1

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (1):
  Remove ModuleType from [LibraryClasses] section

 3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md | 11 ++---------
 README.md                                                |  3 ++-
 2 files changed, 4 insertions(+), 10 deletions(-)

-- 
2.6.3.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
  2017-05-27  2:28 [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section Michael Kinney
@ 2017-05-27  2:28 ` Michael Kinney
  2017-05-27  5:31   ` Gao, Liming
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kinney @ 2017-05-27  2:28 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

bugzilla.tianocore.org/show_bug.cgi?id=548

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md | 11 ++---------
 README.md                                                |  3 ++-
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
index 6cf125a..0700700 100644
--- a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
+++ b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
@@ -37,8 +37,7 @@ These are optional sections.
 
 Defines the EDK II `[LibraryClasses]` section content. The Library Class
 entries are single lines with one or two fields, separated by the pipe "|"
-character. The optional `MODULE_TYPE` refers to the supported Module Type, and
-may be a comma separated list of supported module types.
+character.
 
 The EDK II build system will provide an option to generate an "As Built" INF
 that can be used to distribution binary modules. Since a binary distribution
@@ -65,13 +64,7 @@ in the entries is prohibited.
                          [<Statements>]
 <com_attrs>          ::= {".common"} {<attrs>}
 <attrs>              ::= <Archs> ["," <TS> "LibraryClasses" <attrs>]*
-<Archs>              ::= "." <arch> [<MODULE_TYPE>]
-<MODULE_TYPE>        ::= "." <ModuleType> [<FS> <ModuleType>]*
-<ModuleType>         ::= {"BASE"} {"SEC"} {"PEI_CORE"} {"PEIM"}
-                         {"DXE_CORE"} {"DXE_DRIVER"} {"SMM_CORE"}
-                         {"DXE_SMM_DRIVER"} {"DXE_RUNTIME_DRIVER"}
-                         {"DXE_SAL_DRIVER"} {"UEFI_DRIVER"}
-                         {"UEFI_APPLICATION"} {"USER_DEFINED"}
+<Archs>              ::= "." <arch>
 <Statements>         ::= {<SourceContent>*} {<AsBuiltInfo>}
 <SourceContent>      ::= <TS> {<SourceStmts>} {<MacroDefinition>}
 <SourceStmts>        ::= [<RecInstanceCmt> <Filename> <EOL>] <TS> <Keyword>
diff --git a/README.md b/README.md
index 57e05d2..e256239 100644
--- a/README.md
+++ b/README.md
@@ -192,4 +192,5 @@ Copyright (c) 2007-2017, Intel Corporation. All rights reserved.
 |            | Updated other sections to specify how the build system will evaluate the Feature Flag Expression                                                                                                                                                                                    |               |
 |            | Prohibit using #include statements in UNI files specified in the MODULE_UNI_FILE entry                                                                                                                                                                                              |               |
 | 1.25       | Revised WORKSPACE wording for updated build system that can handle packages located outside of the WORKSPACE directory tree (refer to the TianoCore.org/EDKII website for additional instructions on setting up a development environment).                                         | January 2016  |
-| 1.26       | Convert to GitBooks                                                                                                                                                                                                                                                                 | March 2017    |
+| 1.26       | Convert to GitBooks                                                                                                                                                                                                                                                                 | May 2017      |
+|            | [#548](https://bugzilla.tianocore.org/show_bug.cgi?id=548) [INF spec] INF [LibraryClasses] section should not support ModuleType                                                                                                                                                    |               |
-- 
2.6.3.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
  2017-05-27  2:28 ` Michael Kinney
@ 2017-05-27  5:31   ` Gao, Liming
  0 siblings, 0 replies; 3+ messages in thread
From: Gao, Liming @ 2017-05-27  5:31 UTC (permalink / raw)
  To: Kinney, Michael D, edk2-devel@lists.01.org; +Cc: Zhu, Yonghong, Shaw, Kevin W

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, May 27, 2017 10:28 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
> Subject: [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section
> 
> bugzilla.tianocore.org/show_bug.cgi?id=548
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md | 11 ++---------
>  README.md                                                |  3 ++-
>  2 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> index 6cf125a..0700700 100644
> --- a/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> +++ b/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.md
> @@ -37,8 +37,7 @@ These are optional sections.
> 
>  Defines the EDK II `[LibraryClasses]` section content. The Library Class
>  entries are single lines with one or two fields, separated by the pipe "|"
> -character. The optional `MODULE_TYPE` refers to the supported Module Type, and
> -may be a comma separated list of supported module types.
> +character.
> 
>  The EDK II build system will provide an option to generate an "As Built" INF
>  that can be used to distribution binary modules. Since a binary distribution
> @@ -65,13 +64,7 @@ in the entries is prohibited.
>                           [<Statements>]
>  <com_attrs>          ::= {".common"} {<attrs>}
>  <attrs>              ::= <Archs> ["," <TS> "LibraryClasses" <attrs>]*
> -<Archs>              ::= "." <arch> [<MODULE_TYPE>]
> -<MODULE_TYPE>        ::= "." <ModuleType> [<FS> <ModuleType>]*
> -<ModuleType>         ::= {"BASE"} {"SEC"} {"PEI_CORE"} {"PEIM"}
> -                         {"DXE_CORE"} {"DXE_DRIVER"} {"SMM_CORE"}
> -                         {"DXE_SMM_DRIVER"} {"DXE_RUNTIME_DRIVER"}
> -                         {"DXE_SAL_DRIVER"} {"UEFI_DRIVER"}
> -                         {"UEFI_APPLICATION"} {"USER_DEFINED"}
> +<Archs>              ::= "." <arch>
>  <Statements>         ::= {<SourceContent>*} {<AsBuiltInfo>}
>  <SourceContent>      ::= <TS> {<SourceStmts>} {<MacroDefinition>}
>  <SourceStmts>        ::= [<RecInstanceCmt> <Filename> <EOL>] <TS> <Keyword>
> diff --git a/README.md b/README.md
> index 57e05d2..e256239 100644
> --- a/README.md
> +++ b/README.md
> @@ -192,4 +192,5 @@ Copyright (c) 2007-2017, Intel Corporation. All rights reserved.
>  |            | Updated other sections to specify how the build system will evaluate the Feature Flag Expression
> |               |
>  |            | Prohibit using #include statements in UNI files specified in the MODULE_UNI_FILE entry
> |               |
>  | 1.25       | Revised WORKSPACE wording for updated build system that can handle packages located outside of the WORKSPACE
> directory tree (refer to the TianoCore.org/EDKII website for additional instructions on setting up a development environment).
> | January 2016  |
> -| 1.26       | Convert to GitBooks
> | March 2017    |
> +| 1.26       | Convert to GitBooks
> | May 2017      |
> +|            | [#548](https://bugzilla.tianocore.org/show_bug.cgi?id=548) [INF spec] INF [LibraryClasses] section should not
> support ModuleType
> |               |
> --
> 2.6.3.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-27  5:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-27  2:28 [edk2-InfSpecification PATCH] Remove ModuleType from [LibraryClasses] section Michael Kinney
2017-05-27  2:28 ` Michael Kinney
2017-05-27  5:31   ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox