From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix incremental build failure that override file be removed
Date: Wed, 7 Jun 2017 02:13:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D746787@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1496757155-15452-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, June 06, 2017 9:53 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fix incremental build failure that override file be
>removed
>
>Fix a Incremental build failure. The case is: Both A and B package will
>include a same .h file, and in the driver's packages section, A
>package is listed before B package, so we will use the .h file in the A
>package and build success, then we directly delete the .h file in package
>A, it cause increment build failure since in the AutoGenTimeStamp file
>the .h file in A can't be found.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
>b/BaseTools/Source/Python/AutoGen/AutoGen.py
>index e89b61d..356eb21 100644
>--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
>@@ -4208,10 +4208,12 @@ class ModuleAutoGen(AutoGen):
> return False
>
> with open(self.GetTimeStampPath(),'r') as f:
> for source in f:
> source = source.rstrip('\n')
>+ if not os.path.exists(source):
>+ return False
> if source not in ModuleAutoGen.TimeDict :
> ModuleAutoGen.TimeDict[source] = os.stat(source)[8]
> if ModuleAutoGen.TimeDict[source] > DstTimeStamp:
> return False
> return True
>--
>2.6.1.windows.1
prev parent reply other threads:[~2017-06-07 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 13:52 [Patch] BaseTools: Fix incremental build failure that override file be removed Yonghong Zhu
2017-06-07 2:13 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D746787@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox