Re: [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5 Specification. ***

From: "Gao, Liming" <liming.gao@intel.com>
To: Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "leif.lindholm@arm.com" <leif.lindholm@arm.com>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5 Specification. ***
Date: Thu, 8 Jun 2017 03:32:45 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D746FC9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1496699034-4186-1-git-send-email-supreeth.venkatesh@arm.com>

Supreeth:
  Thanks for your contribution. I review this patch set, and have two comments. 
1) This is added in PI1.5. So, its version check should be with 0x00010032 (1 and 50), not 0x0001000A (1 and 10).  Smm standalone module INF needs to specify PI_SPECIFICATION_VERSION       = 0x00010032.
2) Does the change conform to doc change recorded in below bugzilla?
https://bugzilla.tianocore.org/show_bug.cgi?id=550
https://bugzilla.tianocore.org/show_bug.cgi?id=551
https://bugzilla.tianocore.org/show_bug.cgi?id=552

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Supreeth Venkatesh
>Sent: Tuesday, June 06, 2017 5:44 AM
>To: edk2-devel@lists.01.org
>Cc: leif.lindholm@arm.com; ard.biesheuvel@linaro.org
>Subject: [edk2] [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5
>Specification. ***
>
>***
>PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
>In order to support Management Mode Core Interface, Module Types
>MM_STANDALONE, MM_CORE_STANDALONE are needed.
>PI specification v1.5 defines the following new file types:
>#define EFI_FV_FILETYPE_MM 0x0A
>#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C
>#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E
>The following changes are necessitated in order to support the above changes
>to the specification.
>***
>
>Supreeth Venkatesh (10):
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>  BaseTools: Tools change to support PI v1.5 Specification.
>
> BaseTools/Source/C/GenFfs/GenFfs.c                 |   6 +-
> BaseTools/Source/C/GenFw/GenFw.c                   |   5 +-
> BaseTools/Source/C/Include/Common/PiFirmwareFile.h |   1 +
> BaseTools/Source/Python/AutoGen/GenC.py            | 148
>++++++++++++++++++++-
> BaseTools/Source/Python/AutoGen/GenDepex.py        |  17 ++-
> BaseTools/Source/Python/Common/DataType.py         |   4 +-
> BaseTools/Source/Python/Common/FdfParserLite.py    |   4 +-
> .../Source/Python/CommonDataClass/CommonClass.py   |   6 +-
> .../Source/Python/CommonDataClass/PackageClass.py  |   2 +-
> BaseTools/Source/Python/Eot/FvImage.py             |   1 +
> BaseTools/Source/Python/GenFds/FdfParser.py        |   4 +-
> BaseTools/Source/Python/GenFds/Ffs.py              |   7 +-
> BaseTools/Source/Python/GenFds/FfsInfStatement.py  |   3 +
> .../Source/Python/Workspace/WorkspaceDatabase.py   |   4 +
> BaseTools/Source/Python/build/BuildReport.py       |   4 +-
> BaseTools/Source/Python/build/build.py             |   2 +-
> 16 files changed, 199 insertions(+), 19 deletions(-)
>
>--
>2.7.4
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel