From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54B6B21967BF0 for ; Wed, 7 Jun 2017 20:31:40 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 20:32:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,313,1493708400"; d="scan'208";a="1157931141" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 07 Jun 2017 20:32:48 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Jun 2017 20:32:48 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Jun 2017 20:32:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Thu, 8 Jun 2017 11:32:45 +0800 From: "Gao, Liming" To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "leif.lindholm@arm.com" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5 Specification. *** Thread-Index: AQHS3kT/A42Uy0hhJEqUFfS0SxfjSaIaT0qg Date: Thu, 8 Jun 2017 03:32:45 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D746FC9@shsmsx102.ccr.corp.intel.com> References: <1496699034-4186-1-git-send-email-supreeth.venkatesh@arm.com> In-Reply-To: <1496699034-4186-1-git-send-email-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5 Specification. *** X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 03:31:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Supreeth: Thanks for your contribution. I review this patch set, and have two comme= nts.=20 1) This is added in PI1.5. So, its version check should be with 0x00010032 = (1 and 50), not 0x0001000A (1 and 10). Smm standalone module INF needs to = specify PI_SPECIFICATION_VERSION =3D 0x00010032. 2) Does the change conform to doc change recorded in below bugzilla? https://bugzilla.tianocore.org/show_bug.cgi?id=3D550 https://bugzilla.tianocore.org/show_bug.cgi?id=3D551 https://bugzilla.tianocore.org/show_bug.cgi?id=3D552 Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Supreeth Venkatesh >Sent: Tuesday, June 06, 2017 5:44 AM >To: edk2-devel@lists.01.org >Cc: leif.lindholm@arm.com; ard.biesheuvel@linaro.org >Subject: [edk2] [PATCH 00/10] *** BaseTools: Tools change to support PI v1= .5 >Specification. *** > >*** >PI v1.5 Specification Volume 4 defines Management Mode Core Interface. >In order to support Management Mode Core Interface, Module Types >MM_STANDALONE, MM_CORE_STANDALONE are needed. >PI specification v1.5 defines the following new file types: >#define EFI_FV_FILETYPE_MM 0x0A >#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C >#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E >The following changes are necessitated in order to support the above chang= es >to the specification. >*** > >Supreeth Venkatesh (10): > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > BaseTools: Tools change to support PI v1.5 Specification. > > BaseTools/Source/C/GenFfs/GenFfs.c | 6 +- > BaseTools/Source/C/GenFw/GenFw.c | 5 +- > BaseTools/Source/C/Include/Common/PiFirmwareFile.h | 1 + > BaseTools/Source/Python/AutoGen/GenC.py | 148 >++++++++++++++++++++- > BaseTools/Source/Python/AutoGen/GenDepex.py | 17 ++- > BaseTools/Source/Python/Common/DataType.py | 4 +- > BaseTools/Source/Python/Common/FdfParserLite.py | 4 +- > .../Source/Python/CommonDataClass/CommonClass.py | 6 +- > .../Source/Python/CommonDataClass/PackageClass.py | 2 +- > BaseTools/Source/Python/Eot/FvImage.py | 1 + > BaseTools/Source/Python/GenFds/FdfParser.py | 4 +- > BaseTools/Source/Python/GenFds/Ffs.py | 7 +- > BaseTools/Source/Python/GenFds/FfsInfStatement.py | 3 + > .../Source/Python/Workspace/WorkspaceDatabase.py | 4 + > BaseTools/Source/Python/build/BuildReport.py | 4 +- > BaseTools/Source/Python/build/build.py | 2 +- > 16 files changed, 199 insertions(+), 19 deletions(-) > >-- >2.7.4 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel