public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg Variable: Add missing change in dd59d95e1994
Date: Wed, 21 Jun 2017 13:48:32 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D74CE89@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1498052007-142680-1-git-send-email-star.zeng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, June 21, 2017 9:33 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdeModulePkg Variable: Add missing change in dd59d95e1994
> 
> dd59d95e1994 updated *.c file, but forgot to update *.h file.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> index 55df13191b43..cd0d9568158a 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h
> @@ -2,7 +2,7 @@
>    The internal header file includes the common header files, defines
>    internal structure and functions used by Variable modules.
> 
> -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD License
>  which accompanies this distribution.  The full text of the license may be found at
> @@ -514,7 +514,8 @@ GetFvbInfoByAddress (
>    @param Attributes                 Attribute value of the variable found.
>    @param DataSize                   Size of Data found. If size is less than the
>                                      data, this value contains the required size.
> -  @param Data                       Data pointer.
> +  @param Data                       The buffer to return the contents of the variable. May be NULL
> +                                    with a zero DataSize in order to determine the size buffer needed.
> 
>    @return EFI_INVALID_PARAMETER     Invalid parameter.
>    @return EFI_SUCCESS               Find the specified variable.
> @@ -529,7 +530,7 @@ VariableServiceGetVariable (
>    IN      EFI_GUID          *VendorGuid,
>    OUT     UINT32            *Attributes OPTIONAL,
>    IN OUT  UINTN             *DataSize,
> -  OUT     VOID              *Data
> +  OUT     VOID              *Data OPTIONAL
>    );
> 
>  /**
> --
> 2.7.0.windows.1



      reply	other threads:[~2017-06-21 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 13:33 [PATCH] MdeModulePkg Variable: Add missing change in dd59d95e1994 Star Zeng
2017-06-21 13:48 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D74CE89@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox